Skip to content

Conversation

@khpeet
Copy link

@khpeet khpeet commented Nov 25, 2025

Description

Added logging output for:

  • DroppedAttributesCount
  • DroppedEventsCount
  • DroppedLinksCount

Link to tracking issue

Fixes #14202

Testing

Added validation output to two_spans.out and traces_with_entity_refs.out

Documentation

Added changelog yaml entry summarizing the issue and fix.

@khpeet khpeet requested review from a team and andrzej-stencel as code owners November 25, 2025 16:04
@khpeet khpeet requested a review from bogdandrutu November 25, 2025 16:04
@github-actions github-actions bot added the exporter/debug Issues related to the Debug exporter label Nov 25, 2025
@khpeet khpeet changed the title [exporter/debugexporter] feat: add dropped* attributes to output [exporter/debug] feat: add dropped* attributes to output Nov 25, 2025
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.15%. Comparing base (a0cbea7) to head (fb58f11).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14217      +/-   ##
==========================================
- Coverage   92.17%   92.15%   -0.02%     
==========================================
  Files         668      668              
  Lines       41467    41470       +3     
==========================================
- Hits        38221    38216       -5     
- Misses       2213     2218       +5     
- Partials     1033     1036       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @khpeet for this contribution 🙏 I have one suggestion for the ordering, please let me know what you think.

@khpeet
Copy link
Author

khpeet commented Dec 1, 2025

Thanks for the review @andrzej-stencel - fixed!

Copy link
Member

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

buf.logAttr("Status code", span.Status().Code().String())
buf.logAttr("Status message", span.Status().Message())

buf.logAttr("DroppedAttributesCount", strconv.FormatUint(uint64(span.DroppedAttributesCount()), 10))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit verbose, I'd rather have buf.logAttr("DroppedAttributesCount", span.DroppedAttributesCount()), but this currently results in funny output like DroppedAttributesCount: %!s(uint32=0). Would be nice to fix the logAttr method in a separate change.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 1, 2025

CodSpeed Performance Report

Merging #14217 will degrade performances by 51.67%

Comparing khpeet:main (fb58f11) with main (a0cbea7)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

❌ 4 regressions
✅ 69 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
BenchmarkTraceSizeSpanCount 29 ns 60 ns -51.67%
with_an_existing_value 29 ns 60 ns -51.67%
with_a_duplicate_value 29 ns 60 ns -51.67%
with_a_new_value 29 ns 60 ns -51.67%

@andrzej-stencel andrzej-stencel added the ready-to-merge Code review completed; ready to merge by maintainers label Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exporter/debug Issues related to the Debug exporter ready-to-merge Code review completed; ready to merge by maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

droppedAttributesCount not showing in debug (verbosity: detailed)

4 participants