-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[exporter/debug] feat: add dropped* attributes to output #14217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14217 +/- ##
==========================================
- Coverage 92.17% 92.15% -0.02%
==========================================
Files 668 668
Lines 41467 41470 +3
==========================================
- Hits 38221 38216 -5
- Misses 2213 2218 +5
- Partials 1033 1036 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrzej-stencel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @khpeet for this contribution 🙏 I have one suggestion for the ordering, please let me know what you think.
|
Thanks for the review @andrzej-stencel - fixed! |
andrzej-stencel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
| buf.logAttr("Status code", span.Status().Code().String()) | ||
| buf.logAttr("Status message", span.Status().Message()) | ||
|
|
||
| buf.logAttr("DroppedAttributesCount", strconv.FormatUint(uint64(span.DroppedAttributesCount()), 10)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit verbose, I'd rather have buf.logAttr("DroppedAttributesCount", span.DroppedAttributesCount()), but this currently results in funny output like DroppedAttributesCount: %!s(uint32=0). Would be nice to fix the logAttr method in a separate change.
CodSpeed Performance ReportMerging #14217 will degrade performances by 51.67%Comparing
|
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| ❌ | BenchmarkTraceSizeSpanCount |
29 ns | 60 ns | -51.67% |
| ❌ | with_an_existing_value |
29 ns | 60 ns | -51.67% |
| ❌ | with_a_duplicate_value |
29 ns | 60 ns | -51.67% |
| ❌ | with_a_new_value |
29 ns | 60 ns | -51.67% |
Description
Added logging output for:
Link to tracking issue
Fixes #14202
Testing
Added validation output to
two_spans.outandtraces_with_entity_refs.outDocumentation
Added changelog yaml entry summarizing the issue and fix.