-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Update release tracking issue to match the actual release docs #14250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update release tracking issue to match the actual release docs #14250
Conversation
CodSpeed Performance ReportMerging #14250 will improve performances by 40.88%Comparing
|
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| ⚡ | BenchmarkTraceSizeSpanCount |
60 ns | 46 ns | +30.43% |
| ⚡ | BenchmarkLogsToProto2k |
63.3 µs | 44.9 µs | +40.88% |
| ⚡ | with_a_duplicate_value |
60 ns | 45 ns | +33.33% |
| ⚡ | with_an_existing_value |
60 ns | 45 ns | +33.33% |
| ⚡ | BenchmarkProfilesToProto |
1.6 µs | 1.3 µs | +28.76% |
| ⚡ | BenchmarkTraceSizeBytes |
422.1 µs | 307.5 µs | +37.25% |
| ⚡ | BenchmarkTracesToProto2k |
96 µs | 69.3 µs | +38.39% |
| ⚡ | with_a_new_value |
60 ns | 45 ns | +33.33% |
Footnotes
-
20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14250 +/- ##
=======================================
Coverage 92.16% 92.16%
=======================================
Files 668 668
Lines 41470 41470
=======================================
Hits 38219 38219
Misses 2217 2217
Partials 1034 1034 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| - [ ] Prepare container images release v${CANDIDATE_BETA} | ||
| - [ ] Tag and container images release v${CANDIDATE_BETA} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this new wording a bit confusing. Maybe we should standardize on "otelcol" / "otelcol-contrib" / "otelcol-releases" and "Prepare X release Y" / "Tag and release X vY"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree finding a good name is tricky here. I can switch to otelcol though.
The release tracking issue is a bit misleading, as not all actions are actually performed by the collector release manager.
And some actions don't really reflect the release docs.
This splits the core/contrib/releases releases per their respective managers.
I've also updated the "like" issue to a more recent one.