-
Notifications
You must be signed in to change notification settings - Fork 227
feat: add transform processor as opt-in on custom build #1901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The committers listed above are authorized under a signed CLA. |
56f1fc3 to
5eda47e
Compare
|
@petrusdemelo Shouldn't this new processor be added to default list here: https://github.com/open-telemetry/opentelemetry-lambda/blob/main/collector/lambdacomponents/default.go#L64? |
|
@serkan-ozal I did not want to change the default build for the lambda collector. I just wanted to have it as an opt in option for custom build. But I can definitely add in the default build if that is the desire. |
tylerbenson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have issue with this as long as @serkan-ozal is ok with it. Need to rebase and resolve the conflicts though.
|
@petrusdemelo Ok, makes sense. I am OK with the PR. Could you please resolve the conflicts, then we can merge it. |
|
@petrusdemelo any chance to rebase this PR? |
|
@serkan-ozal yes, I had busy weeks. Will do it this weekend. |
|
@petrusdemelo kindly bump on this |
Description
Add
transform processoras opt-in for custom build usinglambdacomponents.processor.transformtag.