-
Notifications
You must be signed in to change notification settings - Fork 593
chore(otlp): prevent invalid combinations of exporter and protocol #3230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lalitb
merged 2 commits into
open-telemetry:main
from
scottgerring:chore/protocol-cleanup-3
Nov 13, 2025
Merged
chore(otlp): prevent invalid combinations of exporter and protocol #3230
lalitb
merged 2 commits into
open-telemetry:main
from
scottgerring:chore/protocol-cleanup-3
Nov 13, 2025
+200
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd69455 to
19b21c2
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3230 +/- ##
=====================================
Coverage 80.8% 80.8%
=====================================
Files 128 129 +1
Lines 23156 23199 +43
=====================================
+ Hits 18711 18749 +38
- Misses 4445 4450 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@bantonsson , as you looked at the Bigger One, if you have a second! |
bantonsson
approved these changes
Nov 10, 2025
bantonsson
reviewed
Nov 10, 2025
a44621e to
5a0bc7f
Compare
scottgerring
commented
Nov 10, 2025
scottgerring
commented
Nov 10, 2025
0501ba9 to
506399f
Compare
506399f to
3d785f6
Compare
lalitb
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3082
Fixes #3208
Changes
Make invalid combinations of configured exporter features and exporter protocols unrepresentable by using feature flags, and adds support for
OTEL_EXPORTER_OTLP_PROTOCOLAlternative to #3229. In #3229, I've taken the extra step of moving the configurable protocol on the builders down into the HTTP client only, as it is not actually configurable on the tonic exporter - there's no choice.
After speaking to @bantonsson I reckon this is a lighter touch change which feels appropriate.
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes