Skip to content

Conversation

@scottgerring
Copy link
Member

@scottgerring scottgerring commented Nov 10, 2025

Fixes #3082
Fixes #3208

Changes

Make invalid combinations of configured exporter features and exporter protocols unrepresentable by using feature flags, and adds support for OTEL_EXPORTER_OTLP_PROTOCOL

Alternative to #3229. In #3229, I've taken the extra step of moving the configurable protocol on the builders down into the HTTP client only, as it is not actually configurable on the tonic exporter - there's no choice.

After speaking to @bantonsson I reckon this is a lighter touch change which feels appropriate.

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@scottgerring scottgerring force-pushed the chore/protocol-cleanup-3 branch from dd69455 to 19b21c2 Compare November 10, 2025 14:20
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 89.47368% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.8%. Comparing base (5c8dbc8) to head (3d785f6).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-otlp/src/exporter/http/mod.rs 57.1% 3 Missing ⚠️
opentelemetry-otlp/src/exporter/http/logs.rs 50.0% 1 Missing ⚠️
opentelemetry-otlp/src/exporter/http/metrics.rs 50.0% 1 Missing ⚠️
opentelemetry-otlp/src/exporter/http/trace.rs 50.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3230   +/-   ##
=====================================
  Coverage   80.8%   80.8%           
=====================================
  Files        128     129    +1     
  Lines      23156   23199   +43     
=====================================
+ Hits       18711   18749   +38     
- Misses      4445    4450    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scottgerring scottgerring marked this pull request as ready for review November 10, 2025 14:33
@scottgerring scottgerring requested a review from a team as a code owner November 10, 2025 14:33
@scottgerring
Copy link
Member Author

@bantonsson , as you looked at the Bigger One, if you have a second!

@scottgerring scottgerring force-pushed the chore/protocol-cleanup-3 branch 2 times, most recently from a44621e to 5a0bc7f Compare November 10, 2025 15:56
@scottgerring scottgerring force-pushed the chore/protocol-cleanup-3 branch 2 times, most recently from 0501ba9 to 506399f Compare November 10, 2025 16:36
@scottgerring scottgerring force-pushed the chore/protocol-cleanup-3 branch from 506399f to 3d785f6 Compare November 11, 2025 06:42
@lalitb lalitb merged commit 95af815 into open-telemetry:main Nov 13, 2025
27 checks passed
@scottgerring scottgerring deleted the chore/protocol-cleanup-3 branch November 14, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: OTEL_EXPORTER_OTLP_PROTOCOL exists but is never used OTLP Stabilization: Protocol enum ambiguity in API

3 participants