[DATA / V2 BLOCKER] Break out generic srd-2024 items to specific ones
#831
+15,584
−618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustjohnson
approved these changes
Nov 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
srd-2024Magic Items data, breaking out generic magic item data into specific, usable versions of each magic item. For example:"Armor, +1, +2, or +3"was previous a single Magic Item, and was a template for creating +1/2/3/ Armor. This has been replaced with all the different variations that could be generated from this template ready for use at the table;"Plate Armor +1","Studded Leather Armor +3", etc.A complete list of magic items that have received this treatment can be found in the comments on issue #752
EDIT
Added a few more commits to add broken out versions of some items missed in the initial issue, but covered in #817. These Magic Items contained several variations of the same item, but as these variations had different
"rarity"s, the parent item's rarity was undefined. This causes the Open5e API to flag it as a non-magical item. Two birds, one stone.Related Issue
Closes #752
Closes #817
How was this tested?
pytest(all tests passing)