#1455: Don’t cancel a <10m old high temp due to lack of BG data#1456
Open
scottleibrand wants to merge 7 commits intodevfrom
Open
#1455: Don’t cancel a <10m old high temp due to lack of BG data#1456scottleibrand wants to merge 7 commits intodevfrom
scottleibrand wants to merge 7 commits intodevfrom
Conversation
Contributor
Author
|
Testing with oref0-ns-loop purposefully broken: Will add a |
Contributor
Author
|
Looking good now in testing: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1455
When running offline with multiple rigs, the rig with connected CGM will set a high temp, and the other without CGM data will immediately cancel it.
Let's not cancel a high temp due to lack of BG data if the temp has been running for less than 10m.