Open
Conversation
51cbcc9 to
81af6b1
Compare
Author
|
About the test error:
cat stdout_output | jq ".CSFGlucoseData | first" | grep -q null || fail_test "oref0-autotune-prep with carbhistory didn't contain expected CSF Glucose Data"I guess the problem is about a bug on original meal dedupe in meal/history. that set Debugging the original code, there are two duplicates meal entries with the same timestamp. |
`generate` functions must be the entry-points for unknown inputs. Inputs must be validated and eventually transformed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work In Progress.
This could be the 0.8 release.
Currently, developing on the oref0 repository is very hard for the open source community.
It's hard to understand what variables contain, and there are a lot of javascript errors (undeclared variables, multiple types for the same variables, etc...).
This is the first draft where I've refactored a lot of
lib/scripts in Typescript. This will allow to have types and interfaces for objects, with the opportunity to document them.Tests
All tests passes, except for the
test-autotune-prepintests/command-behavior.tests.sh. Honestly I can't understand why there is a check for anullvalue:Changes
Some of changes are:
moment,moment-timezoneandlodashfrom dependencies: smaller bundles for apps like (iAPS). iAPS is 50-75% fasterCONTRIBUTING.md): just open the project in VSCode, and you will have your development environment without install dependencies in your systemCONTRIBUTING.mdFuture changes
anywhere not completely migrated)If you want to contribute, please add a PR to my repository.