feat: require explicit activity type selection when logging activities #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonymoususer72041
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the default preselection of the "Call" activity type when logging an activity and introduces validation to require an explicit choice. The Activity Type dropdown now starts with a placeholder option and the form is blocked if an activity type is not selected. The requirement is enforced both client-side (for immediate feedback) and server-side (to prevent invalid submissions when JavaScript is unavailable).
Motivation
Previously, "Call" was preselected by default, which made it easy to unintentionally log a call when submitting quickly without making a conscious selection. Requiring an explicit activity type choice reduces accidental data entry and improves the accuracy of activity tracking in day-to-day use.