fix(activity): preserve job order regarding when editing #704
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where editing an Activity could unintentionally reset the "Regarding" field from a specific Job Order to "General". The root cause was fragile preselection logic in the edit UI that relied on comparing rendered text, which could fail (for example when the dropdown option text includes markers like
(*)).The edit modal now preselects the correct Job Order using the underlying
jobOrderIDrather than display text. In addition, saving "General" is normalized so thatactivity.joborder_idis persisted as SQLNULLinstead of inconsistent sentinel values created by legacy paths (such as0or-1).Finally, the PR includes a schema migration that updates existing rows and converts legacy
activity.joborder_idvalues of0and-1toNULL, ensuring "General" is represented consistently across old and new data.