security: restrict ajax.php to installer actions when INSTALL_BLOCK is missing #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the installer/upgrade mode is active (INSTALL_BLOCK missing), ajax.php now only allows installer AJAX actions (install:*). All other AJAX requests are rejected early with a standard XML error response.
Motivation
During upgrades, index.php is already blocked when INSTALL_BLOCK is missing, but ajax.php remained accessible. This could allow existing sessions or stale UI tabs to keep sending AJAX requests while schema migrations are running, increasing the risk of unintended changes or inconsistent state.