Generalised data sampler support #496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sukh-P
commented
Nov 12, 2025
pyproject.toml
Outdated
|
|
||
| dependencies = [ | ||
| "ocf-data-sampler>=0.6.0", | ||
| "ocf-data-sampler@git+https://github.com/openclimatefix/ocf-data-sampler.git@dev-one-torch-dataset", |
Member
Author
There was a problem hiding this comment.
This will need updating after the ocf-data-sampler changes are merged in
dfulu
reviewed
Nov 14, 2025
dfulu
reviewed
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Changes for PVNet to support related changes in
ocf-data-samplerto have one dataset/schema openclimatefix/ocf-data-sampler#375The changes here include:
How has this been tested?
Through unit tests and also running training with these changes and the related ocf-data-sampler changes, tracking results here https://wandb.ai/openclimatefix/test_new_data_sampler to check no large changes have occured to outputs