Fix cleared at use in contribution time series #11165
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… indicates its cleared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve opencollective/opencollective#8266
This change updates contribution time series to use the new
clearedAtfield in the transaction. This matches with theeffectiveDatefield that is now default on the transaction CSV export.Additionally, it fixes the record of the clearedAt date for stripe contributions, using the balanceTransaction available_on date to correctly represent when funds are available. The difference between charge create date and balance available date is significant on delayed payments such as SEPA and ACH where funds can take sometimes weeks to clear.
Such as this example:
