Added KEEP_ALIVE_TIME_MS period in favor of web interface; #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
The newly added 'Power saving' option by @basilfx is great. If activated, it has one drawback though which results in adding delay while web pages are served.
Added 'keepAlive' check to fix that issue caused by 'delay (sleep)' at the end of 'loop ()' function.
This way 'sleep' will be set to 0 milliseconds for the period of 'KEEP_ALIVE_TIME_MS' after 'last_page_load' time which is set to reasonable 30 seconds. This should be enough if one needs to browse around the web interface without being disturbed by annoying delay in page serve.
Additionally, some refactoring was done, and early exit added (sleep > 0) for the 'delay(sleep)' call instead of calling 'delay(0)'.