feat: add PERSISTENT_SUBSECTION_GRADE_CHANGED#545
Draft
ormsbee wants to merge 4 commits intoopenedx:mainfrom
Draft
feat: add PERSISTENT_SUBSECTION_GRADE_CHANGED#545ormsbee wants to merge 4 commits intoopenedx:mainfrom
ormsbee wants to merge 4 commits intoopenedx:mainfrom
Conversation
Author
|
@bmtcril: May I trouble you to take a pass at this? I'm not sure what the Avro evolvable schema errors are about, but I'll look into it tomorrow. I just wanted to get a sanity check on the payload and comments. I still need to hook this up to an openedx-platform branch and test to make sure we're really spitting out what I think we're spitting out, especially for the |
Author
|
@bmtcril: May I grab some time with you on this tomorrow? I'm getting a circular reference error and I do not understand what is going on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of #542
Description
We already have a PERSISTENT_GRADE_CHANGED event, but we do not have a corresponding event for the subsection.
This mostly borrows the field data already calculated for openedx-platform's SUBSECTION_GRADE_CALCULATED tracking event.
I don't love the fact that we are putting the model name in the event name (
PersistentSubsectionGrade), but I think it's better to be consistent with the already existing convention for emitting the course grade change event.Checklists
Check off if complete or not applicable:
Merge Checklist:
Post Merge:
finished.