OEL-4230: Remove spaceless from templates and fix for tests whitespace. #710
Conversation
|
🚀 Deployed on https://preview-710--oelibrary.netlify.app |
| {% macro render(items, pills, tabs, tabs_content, vertical, full_width, alignment, id, nav, navbar, attributes) %} | ||
| {% apply spaceless %} | ||
| {% import _self as navigation %} | ||
| {% import _self as navigation %} |
There was a problem hiding this comment.
I think identation is wrong.
|
|
||
| const escapeRegExp = (value) => value.replace(/[.*+?^${}()|[\]\\]/g, "\\$&"); | ||
| let start = 0; | ||
| let seenLineBreak = false; |
There was a problem hiding this comment.
I think the removals of the spaceless is ok, Drupal core has done this, Im wondering if we should remove spaces from the tests. This is altering the real output, drupal-attribute is ok since will be the expected result when templates go through Drupal, but not sure if spaces/break lines are removed, so this is not what the HTML will be.
Do we want to remove the trim of extra spaces and break lines? If we remove spaceless and tests start to fail that tells me that we are not replacing the functionality. Do we want to keep it as it was?
I've seen we use - or ~to remove extra spaces in some templates, assuming we keep the same functinality maybe we can work around that but may not fit in all scenarios.
No description provided.