Skip to content

Conversation

@SoulPancake
Copy link
Member

@SoulPancake SoulPancake commented Oct 31, 2025

Description

This is for streamed list objects support in the Java SDK. This was used to generate the API layer for streamed list objects endpoint which was earlier intentionally excluded due to lack of support.

What problem is being solved?

For #76 in the java-sdk
#76

Generates API layer for openfga/java-sdk#244

How is it being solved?

What changes are made to solve it?

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 31, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

A Makefile modification updates the Java client build process to use the build-client-streamed target instead of build-client, changing the selected build variant without altering other build steps or parameters.

Changes

Cohort / File(s) Summary
Java client build target change
Makefile
Modified Java client build invocation to use streamed variant by replacing build-client target with build-client-streamed

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2–3 minutes

  • Single-line modification with direct string replacement of make target
  • Verify that build-client-streamed target exists and produces expected output format for Java client builds

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "feat(java-sdk): Makefile changes for streamed list objects generate" is clearly related to the changeset. It identifies the primary change as Makefile modifications for supporting streamed list objects in the Java SDK, which aligns with both the raw summary (switching to the streamed build variant) and the PR objectives (enabling support for streamed list objects). While the word "generate" could be slightly more explicit about what is being generated (the API layer), the title is sufficiently clear when taken in context—a teammate scanning history would understand this enables streamed list objects functionality in the Java SDK through Makefile changes.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SoulPancake SoulPancake marked this pull request as ready for review October 31, 2025 12:39
@SoulPancake SoulPancake requested a review from a team as a code owner October 31, 2025 12:39
Copilot AI review requested due to automatic review settings October 31, 2025 12:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enables streaming endpoint support in the Java SDK by switching from the standard build target to the streamed variant. This aligns Java with Python, which already uses the streamed build process.

  • Changes the Java SDK build process to include streaming endpoints from the OpenFGA API
  • Specifically adds support for /streamed-list-objects endpoint that was previously excluded

@rhamzeh rhamzeh added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit 5c3efea Nov 19, 2025
13 of 15 checks passed
@rhamzeh rhamzeh deleted the feat/java-sdk/streaming-list-objects branch November 19, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants