8359472: JVM crashes when attaching a dynamic agent before JVMTI_PHASE_LIVE

[fandreuz]

This PR contains a clean backport of JDK-8359472. JDK-8370730 is a follow-up which resolves a small problem in the test.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8359472 needs maintainer approval
• JDK-8370730 needs maintainer approval

Issues

• JDK-8359472: JVM crashes when attaching a dynamic agent before JVMTI_PHASE_LIVE (Bug - P3 - Requested)
• JDK-8370730: Test serviceability/attach/EarlyDynamicLoad/EarlyDynamicLoad.java needs to be resilient about warnings (Bug - P4 - Requested)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/340/head:pull/340
$ git checkout pull/340

Update a local copy of the PR:
$ git checkout pull/340
$ git pull https://git.openjdk.org/jdk25u.git pull/340/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 340

View PR using the GUI difftool:
$ git pr show -t 340

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/340.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fandreuzzi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @fandreuz This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (0803fc4d)
• 00: Full (86920580)

[fandreuz]

/approval request Clean backport. Fixes a crash happening when an agent tries to load before live phase. The fix is simple and tests are attached to verify all use cases. Passes tier1 and tier2.

[openjdk]

@fandreuz
8359472: The approval request has been created successfully.

[fandreuz]

Tests in this PR needs a small tweak, see https://bugs.openjdk.org/browse/JDK-8370730.

I'll reopen the backport request once the related PR is merged.

[shipilev]

Looks like JDK-8370730 is in, would you like to finish this up? We are still in 25.0.2 -> 25.0.3 handover limbo, but we can integrate when 25.0.3 opens.

[fandreuz]

/issue add JDK-8370730

[openjdk]

@fandreuz
Adding additional issue to issue list: 8370730: Test serviceability/attach/EarlyDynamicLoad/EarlyDynamicLoad.java needs to be resilient about warnings.

[fandreuz]

/approval request Clean backport. Fixes a crash happening when an agent tries to load before live phase. The fix is simple and tests are attached to verify all use cases. Passes tier1 and tier2.

[openjdk]

@fandreuz
8359472: The approval request was already up to date.
8370730: The approval request has been created successfully.

[shipilev]

Both commits look clean, so the compound PR is also clean. Approving.