Skip to content

Conversation

@KavyaKS94
Copy link

@KavyaKS94 KavyaKS94 commented Oct 31, 2025

clean backport. Tested changes locally


Progress

  • JDK-8366908 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8366908: Use a different class for testing JDK-8351654 (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/350/head:pull/350
$ git checkout pull/350

Update a local copy of the PR:
$ git checkout pull/350
$ git pull https://git.openjdk.org/jdk25u.git pull/350/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 350

View PR using the GUI difftool:
$ git pr show -t 350

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/350.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 31, 2025

👋 Welcome back KavyaKS94! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 31, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 6765a9d775b5bd3d1b36090038060762f976d174 8366908: Use a different class for testing JDK-8351654 Oct 31, 2025
@openjdk
Copy link

openjdk bot commented Oct 31, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 31, 2025
@openjdk
Copy link

openjdk bot commented Oct 31, 2025

⚠️ @KavyaKS94 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 31, 2025
@KavyaKS94
Copy link
Author

/approval 8366908 request Use a different class to provoke the VerifyError on the bootclass path using CFLH. Clean backport.

@openjdk
Copy link

openjdk bot commented Oct 31, 2025

@KavyaKS94
8366908: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 31, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 31, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants