Skip to content

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Nov 5, 2025

Clean backport of openjdk/jdk#26173 PR with prerequisite commits.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8361224 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8360507 needs maintainer approval
  • JDK-8351073 needs maintainer approval
  • JDK-8362352 needs maintainer approval
  • JDK-8359756 needs maintainer approval

Issues

  • JDK-8351073: [macos] jpackage produces invalid Java runtime DMG bundles (Bug - P4 - Requested)
  • JDK-8361224: [macos] MacSignTest.testMultipleCertificates failed (Bug - P3 - Requested)
  • JDK-8360507: JPKG002-006: SigningPackageTest: appOutput.txt cannot be found in user home directory and output doesn't contain: origin=Developer ID Application: jpackage.openjdk.java.net (Bug - P4 - Requested)
  • JDK-8362352: Fix references to non-existing resource strings (Bug - P4 - Requested)
  • JDK-8359756: Bug in RuntimePackageTest.testName test (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/360/head:pull/360
$ git checkout pull/360

Update a local copy of the PR:
$ git checkout pull/360
$ git pull https://git.openjdk.org/jdk25u.git pull/360/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 360

View PR using the GUI difftool:
$ git pr show -t 360

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/360.diff

Using Webrev

Link to Webrev Comment

Alexander Matveev and others added 5 commits November 4, 2025 08:08
…nd in user home directory and output doesn't contain: origin=Developer ID Application: jpackage.openjdk.java.net

Reviewed-by: asemenyuk
@alexeysemenyukoracle
Copy link
Member Author

/issue add 8361224 8351073 8360507 8362352 8359756

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 5, 2025

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 5, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 03230f8565a4eea41ce13827165b6bbff5eaec68 8351073: [macos] jpackage produces invalid Java runtime DMG bundles Nov 5, 2025
@openjdk
Copy link

openjdk bot commented Nov 5, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Nov 5, 2025
@openjdk
Copy link

openjdk bot commented Nov 5, 2025

@alexeysemenyukoracle
Adding additional issue to issue list: 8361224: [macos] MacSignTest.testMultipleCertificates failed.
This issue is referenced in the PR title - it will now be updated.

Adding additional issue to issue list: 8360507: JPKG002-006: SigningPackageTest: appOutput.txt cannot be found in user home directory and output doesn't contain: origin=Developer ID Application: jpackage.openjdk.java.net.

Adding additional issue to issue list: 8362352: Fix references to non-existing resource strings.

Adding additional issue to issue list: 8359756: Bug in RuntimePackageTest.testName test.

@mlbridge
Copy link

mlbridge bot commented Nov 5, 2025

Webrevs

@alexeysemenyukoracle
Copy link
Member Author

@aivanov-jdk please review

Copy link
Member

@aivanov-jdk aivanov-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that all the five patches apply cleanly.

@openjdk
Copy link

openjdk bot commented Nov 10, 2025

⚠️ @alexeysemenyukoracle This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@alexeysemenyukoracle
Copy link
Member Author

/approval request

@openjdk
Copy link

openjdk bot commented Nov 10, 2025

@alexeysemenyukoracle
8351073: The approval request has been created successfully.
8361224: The approval request has been created successfully.
8360507: The approval request has been created successfully.
8362352: The approval request has been created successfully.
8359756: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 10, 2025
@alexeysemenyukoracle
Copy link
Member Author

/approval cancel

@alexeysemenyukoracle
Copy link
Member Author

This issue is not critical for 25.0.2. I'll retarget it to 25.0.3.

@openjdk
Copy link

openjdk bot commented Nov 11, 2025

@alexeysemenyukoracle
8351073: The approval request has been cancelled successfully.
8361224: The approval request has been cancelled successfully.
8360507: The approval request has been cancelled successfully.
8362352: The approval request has been cancelled successfully.
8359756: The approval request has been cancelled successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants