-
Notifications
You must be signed in to change notification settings - Fork 110
8351073: [macos] jpackage produces invalid Java runtime DMG bundles #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8351073: [macos] jpackage produces invalid Java runtime DMG bundles #360
Conversation
Reviewed-by: asemenyuk
Reviewed-by: asemenyuk
…nd in user home directory and output doesn't contain: origin=Developer ID Application: jpackage.openjdk.java.net Reviewed-by: asemenyuk
Reviewed-by: almatvee
Reviewed-by: almatvee
|
/issue add 8361224 8351073 8360507 8362352 8359756 |
|
👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
@alexeysemenyukoracle Adding additional issue to issue list: Adding additional issue to issue list: Adding additional issue to issue list: |
|
@aivanov-jdk please review |
aivanov-jdk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that all the five patches apply cleanly.
|
|
|
/approval request |
|
@alexeysemenyukoracle |
|
/approval cancel |
|
This issue is not critical for 25.0.2. I'll retarget it to 25.0.3. |
|
@alexeysemenyukoracle |
Clean backport of openjdk/jdk#26173 PR with prerequisite commits.
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/360/head:pull/360$ git checkout pull/360Update a local copy of the PR:
$ git checkout pull/360$ git pull https://git.openjdk.org/jdk25u.git pull/360/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 360View PR using the GUI difftool:
$ git pr show -t 360Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/360.diff
Using Webrev
Link to Webrev Comment