-
Notifications
You must be signed in to change notification settings - Fork 342
Add security provider earlier in bootstrap process #5749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add security provider earlier in bootstrap process #5749
Conversation
Signed-off-by: Terry Quigley <[email protected]>
Signed-off-by: Terry Quigley <[email protected]>
Signed-off-by: Terry Quigley <[email protected]>
Signed-off-by: Terry Quigley <[email protected]>
1f521b2 to
9a9a812
Compare
Signed-off-by: Terry Quigley <[email protected]>
Signed-off-by: Terry Quigley <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5749 +/- ##
==========================================
- Coverage 73.12% 73.03% -0.10%
==========================================
Files 435 435
Lines 26665 26665
Branches 3999 3999
==========================================
- Hits 19499 19475 -24
- Misses 5249 5275 +26
+ Partials 1917 1915 -2
🚀 New features to boost your workflow:
|
Signed-off-by: Terry Quigley <[email protected]>
Signed-off-by: Terry Quigley <[email protected]>
|
@cwperks Is it possible to have this backported to the next 3.3.x release? |
@peterzhuamazon can this be included? |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/security/backport-3.3 3.3
# Navigate to the new working tree
pushd ../.worktrees/security/backport-3.3
# Create a new branch
git switch --create backport/backport-5749-to-3.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6f2b39a6bfd826622289afd4c3728adcc4bcfa49
# Push it to GitHub
git push --set-upstream origin backport/backport-5749-to-3.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/security/backport-3.3Then, create a pull request where the |
|
Need manual backport and this will be the last PR to catch 3.3.2 release train as we need time to integTests. |
) (#5756) Signed-off-by: Terry Quigley <[email protected]> Signed-off-by: Terry Quigley <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: Terry Quigley <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]>
|
I can confirm that the last changes we retested as stated originally and the reran Bulk Integration Test action - all tests passing. |
Description
[Describe what this change achieves]
Bug fix, Refactoring
To aid the use of BCFKS using more JDKs the loading of the BCFIPS provider is moved earlier in the bootstrap process to ensure it is present before loading SSL settings
Using BCFKS as the default keystore can fail
Related Issues
#3420
opensearch-project/documentation-website#11412
Is this a backport? If so, please add backport PR # and/or commits #, and remove
backport-failedlabel from the original PR.Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
Testing
Ran the Bulk Integration Test action - all tests passing.
Tested custom build of Security plugin with the change on local deployment.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.