-
Notifications
You must be signed in to change notification settings - Fork 209
OCPBUGS-64732: lib/resourcemerge: Add support for hostUsers flag #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When a pod spec is being ensured, hostUsers flag is not taken into account. This is now fixed and hostUsers is copied into the resulting pod spec.
|
@tchap: This pull request references Jira Issue OCPBUGS-64732, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
wking
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tchap, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@tchap: This PR has been marked as verified by In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
@tchap: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@tchap: Jira Issue Verification Checks: Jira Issue OCPBUGS-64732 Jira Issue OCPBUGS-64732 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Linux user namespace support became generally available in OpenShift 4.20. No 4.20 release image manifests are been setting that property yet: $ oc adm release extract --to manifests quay.io/openshift-release-dev/ocp-release:4.20.3-x86_64
Extracted release payload from digest sha256:24da924c84a1dfa28525f85525356cf1ac4fbe23faec7c66d1890e0b3bcba7a0 created at 2025-11-06T16:06:38Z
$ grep -ir hostuser manifests
...no Deployments or other consumers, just CRDs and comments and things...But they might try to set it in later 4.20.z releases. Backport this small change, just to be safe. /cherry-pick release-4.20 |
|
@wking: new pull request created: #1259 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
When a pod spec is being ensured,
hostUsersflag is not taken into account.This is now fixed and
hostUsersis copied into the resulting pod spec.