Skip to content

Conversation

@tchap
Copy link
Contributor

@tchap tchap commented Nov 6, 2025

When a pod spec is being ensured, hostUsers flag is not taken into account.
This is now fixed and hostUsers is copied into the resulting pod spec.

When a pod spec is being ensured, hostUsers flag is not taken into
account. This is now fixed and hostUsers is copied into the resulting
pod spec.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 6, 2025
@openshift-ci-robot
Copy link
Contributor

@tchap: This pull request references Jira Issue OCPBUGS-64732, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jiajliu

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

When a pod spec is being ensured, hostUsers flag is not taken into account.
This is now fixed and hostUsers is copied into the resulting pod spec.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tchap, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2025
@tchap
Copy link
Contributor Author

tchap commented Nov 6, 2025

/retest

@tchap
Copy link
Contributor Author

tchap commented Nov 6, 2025

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 6, 2025
@openshift-ci-robot
Copy link
Contributor

@tchap: This PR has been marked as verified by https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1986525891198455808.

In response to this:

/verified by https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1986525891198455808

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tchap
Copy link
Contributor Author

tchap commented Nov 6, 2025

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a26c85e and 2 for PR HEAD ce5cac7 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2025

@tchap: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8529b7d into openshift:main Nov 7, 2025
16 checks passed
@openshift-ci-robot
Copy link
Contributor

@tchap: Jira Issue Verification Checks: Jira Issue OCPBUGS-64732
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-64732 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

When a pod spec is being ensured, hostUsers flag is not taken into account.
This is now fixed and hostUsers is copied into the resulting pod spec.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wking
Copy link
Member

wking commented Nov 7, 2025

Linux user namespace support became generally available in OpenShift 4.20. No 4.20 release image manifests are been setting that property yet:

$ oc adm release extract --to manifests quay.io/openshift-release-dev/ocp-release:4.20.3-x86_64
Extracted release payload from digest sha256:24da924c84a1dfa28525f85525356cf1ac4fbe23faec7c66d1890e0b3bcba7a0 created at 2025-11-06T16:06:38Z
$ grep -ir hostuser manifests
...no Deployments or other consumers, just CRDs and comments and things...

But they might try to set it in later 4.20.z releases. Backport this small change, just to be safe.

/cherry-pick release-4.20

@openshift-cherrypick-robot

@wking: new pull request created: #1259

In response to this:

Linux user namespace support became generally available in OpenShift 4.20. No 4.20 release image manifests are been setting that property yet:

$ oc adm release extract --to manifests quay.io/openshift-release-dev/ocp-release:4.20.3-x86_64
Extracted release payload from digest sha256:24da924c84a1dfa28525f85525356cf1ac4fbe23faec7c66d1890e0b3bcba7a0 created at 2025-11-06T16:06:38Z
$ grep -ir hostuser manifests
...no Deployments or other consumers, just CRDs and comments and things...

But they might try to set it in later 4.20.z releases. Backport this small change, just to be safe.

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants