OCPKUEUE-319 - Pending Workloads for ClusterQueue #889

anahas-redhat · 2025-11-03T20:30:01Z

This commit adds comprehensive e2e tests for the pending workloads visibility API
functionality, including RBAC verification and priority ordering validation.

Key changes:

Add e2e tests for ClusterQueue pending workloads visibility API

Verify admin users can access ClusterQueue pending workloads
Test priority ordering of pending workloads (high, medium, low)
Validate pending workloads list becomes empty after execution
Enhance test utilities

Add helper functions for creating test resources with builder pattern
Add ClusterQueue, LocalQueue, and ResourceFlavor wrapper builders
Add CreateWithObject methods that return created objects and cleanup functions
Add GenerateName support for test resource builders

Jira link:
https://issues.redhat.com/browse/OCPKUEUE-319

openshift-ci · 2025-11-03T20:30:08Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

anahas-redhat · 2025-11-03T20:32:02Z

/hold

anahas-redhat · 2025-11-03T21:44:20Z

/retest

anahas-redhat · 2025-11-03T21:45:48Z

@rphillips @cpmeadors can you please take a look at this PR when you have chance? Thank you.

anahas-redhat · 2025-11-03T21:46:34Z

/unhold

test/e2e/e2e_visibility_on_demand_test.go

anahas-redhat · 2025-11-05T17:02:53Z

/retest

kannon92 · 2025-11-05T17:07:08Z

Kueue Metrics Metrics Infrastructure should have ServiceMonitor created [metrics]
/go/src/github.com/openshift/kueue-operator/test/e2e/e2e_metrics_test.go:177
[FAILED] in [It] - /go/src/github.com/openshift/kueue-operator/test/e2e/e2e_metrics_test.go:186 @ 11/05/25 15:16:48.713
• [FAILED] [0.040 seconds]
Kueue Metrics Metrics Infrastructure [It] should have ServiceMonitor created [metrics]
/go/src/github.com/openshift/kueue-operator/test/e2e/e2e_metrics_test.go:177
[FAILED] Expected
: metrics
to equal
: https
In [It] at: /go/src/github.com/openshift/kueue-operator/test/e2e/e2e_metrics_test.go:186 @ 11/05/25 15:16:48.713

I think you should rebase your PR if you haven't tried that yet.

anahas-redhat · 2025-11-05T21:50:46Z

/retest

anahas-redhat · 2025-11-06T21:44:08Z

Executions for 4.19 are failing for different reasons, the last one I'll print below. However, all tests are passing.
`error: invalid reference format
make: *** [Makefile:245: run-must] Error 1
{"component":"entrypoint","error":"wrapped process failed: exit status 2","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2025-11-06T18:11:11Z"}
error: failed to execute wrapped command: exit status 2
INFO[2025-11-06T18:11:12Z] Step test-e2e-4-19-kueue-must-gather failed after 53s.
INFO[2025-11-06T18:11:12Z] Running step test-e2e-4-19-gather-must-gather.
INFO[2025-11-06T18:13:05Z] Step test-e2e-4-19-gather-must-gather succeeded after 1m53s.
INFO[2025-11-06T18:13:05Z] Step phase post failed after 2m47s.
INFO[2025-11-06T18:13:05Z] Releasing cluster claims for test test-e2e-4-19
INFO[2025-11-06T18:13:05Z] Ran for 1h4m13s
ERRO[2025-11-06T18:13:05Z] Some steps failed:
ERRO[2025-11-06T18:13:05Z]

could not run steps: step test-e2e-4-19 failed: "test-e2e-4-19" post steps failed: "test-e2e-4-19" pod "test-e2e-4-19-kueue-must-gather" failed: could not watch pod: the pod ci-op-8q53mys4/test-e2e-4-19-kueue-must-gather failed after 51s (failed containers: test): ContainerFailed one or more containers exited`

anahas-redhat · 2025-11-06T21:44:29Z

/retest

MaysaMacedo · 2025-11-07T01:31:39Z

test/e2e/e2e_visibility_on_demand_test.go

+	return createdPriorityClass, cleanup, nil
+}
+
+// createServiceAccount creates a ServiceAccount in the specified namespaceand returns the created object


typo: namespaceand

MaysaMacedo · 2025-11-07T01:33:26Z

/lgtm

kannon92 · 2025-11-07T13:55:31Z

/cherry-pick release-1.2

openshift-cherrypick-robot · 2025-11-07T13:55:33Z

@kannon92: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rphillips · 2025-11-07T15:53:51Z

test/e2e/e2e_operator_test.go

 			Expect(err).NotTo(HaveOccurred())

-			cleanupClusterQueue, err = testutils.CreateClusterQueue(kueueClient)
+			cleanupClusterQueue, err = testutils.CreateClusterQueue(context.TODO(), kueueClient)


let's use one context at the top of the function.

… visibility API This commit adds comprehensive e2e tests for the pending workloads visibility API functionality, including RBAC verification and priority ordering validation. Key changes: - Add e2e tests for ClusterQueue pending workloads visibility API * Verify admin users can access ClusterQueue pending workloads * Test priority ordering of pending workloads (high, medium, low) * Validate pending workloads list becomes empty after execution - Enhance test utilities * Add helper functions for creating test resources with builder pattern * Add ClusterQueue, LocalQueue, and ResourceFlavor wrapper builders * Add CreateWithObject methods that return created objects and cleanup functions * Add GenerateName support for test resource builders

… visibility API -Add e2e tests for ClusterQueue pending workloads visibility API Verify admin users can access ClusterQueue pending workloads Test priority ordering of pending workloads (high, medium, low) Validate pending workloads list becomes empty after execution Enhance test utilities Add helper functions for creating test resources with builder pattern Add ClusterQueue, LocalQueue, and ResourceFlavor wrapper builders Add CreateWithObject methods that return created objects and cleanup functions Add GenerateName support for test resource builders

- Replace hardcoded 'kueue.openshift.io/managed' with testutils.OpenShiftManagedLabel - Fix context usage in namespace creation (use ctx instead of context.TODO()) - Improves code maintainability and consistency across test suite

…r_test.go - Removed duplicate import of k8s.io/apimachinery/pkg/api/errors - Updated reference from 'errors' to 'apierrors' alias for consistency - Replaced context.TODO() with ctx parameter - No functional changes to e2e_visibility_on_demand_test.go

MaysaMacedo

/lgtm

MaysaMacedo · 2025-11-10T17:44:33Z

test/e2e/e2e_visibility_on_demand_test.go

+			DeferCleanup(cleanupLowPriorityClass)
+
+			By("Creating RBAC kueue-batch-admin-role for Visibility API")
+			kueueTestSA, err := createServiceAccount(ctx, namespaceA.Name)


minor suggestion:

When a namespace is created 3 service accounts already exists by default there, so you could re-use one of them instead of creating a new one:

$ kubectl get serviceaccount -n test NAME SECRETS AGE builder 1 2m4s default 1 2m4s deployer 1 2m4s

rphillips · 2025-11-10T19:13:11Z

/approve

openshift-ci · 2025-11-10T19:13:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anahas-redhat, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rphillips]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kannon92 · 2025-11-10T21:39:17Z

/cherry-pick release-1.2

openshift-cherrypick-robot · 2025-11-10T21:39:20Z

@kannon92: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2025-11-10T23:03:47Z

@anahas-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-cherrypick-robot · 2025-11-10T23:08:06Z

@kannon92: new pull request created: #960

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2025

anahas-redhat marked this pull request as ready for review November 3, 2025 20:31

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2025

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2025

openshift-ci bot requested review from kannon92 and sohankunkerkar November 3, 2025 20:32

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2025

MaysaMacedo reviewed Nov 4, 2025

View reviewed changes

anahas-redhat changed the title ~~OCPKUEUE-318 - Pending Workloads for ClusterQueue~~ OCPKUEUE-319 - Pending Workloads for ClusterQueue Nov 4, 2025

rphillips reviewed Nov 4, 2025

View reviewed changes

test/e2e/e2e_visibility_on_demand_test.go Outdated Show resolved Hide resolved

anahas-redhat force-pushed the workloads_clusterqueue branch from 02f442b to dbfc853 Compare November 5, 2025 19:39

anahas-redhat mentioned this pull request Nov 6, 2025

OCPKUEUE-342 - Test automation - LocalQueue for Pending Workloads #906

Merged

openshift-ci bot assigned MaysaMacedo Nov 7, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2025

MaysaMacedo reviewed Nov 7, 2025

View reviewed changes

rphillips reviewed Nov 7, 2025

View reviewed changes

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2025

anahas-redhat added 5 commits November 10, 2025 11:56

test: refactor visibility e2e tests

0a60dcd

anahas-redhat force-pushed the workloads_clusterqueue branch from 950c461 to 5ac9a81 Compare November 10, 2025 14:59

MaysaMacedo reviewed Nov 10, 2025

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2025

openshift-merge-bot bot merged commit 8d21fe7 into openshift:main Nov 10, 2025
17 checks passed

openshift-cherrypick-robot mentioned this pull request Nov 10, 2025

[release-1.2] OCPKUEUE-319 - Pending Workloads for ClusterQueue #960

Merged

anahas-redhat deleted the workloads_clusterqueue branch November 11, 2025 12:07

OCPKUEUE-319 - Pending Workloads for ClusterQueue #889

OCPKUEUE-319 - Pending Workloads for ClusterQueue #889

Uh oh!

Conversation

anahas-redhat commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Nov 3, 2025

Uh oh!

anahas-redhat commented Nov 3, 2025

Uh oh!

anahas-redhat commented Nov 3, 2025

Uh oh!

anahas-redhat commented Nov 3, 2025

Uh oh!

anahas-redhat commented Nov 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anahas-redhat commented Nov 5, 2025

Uh oh!

kannon92 commented Nov 5, 2025

Uh oh!

anahas-redhat commented Nov 5, 2025

Uh oh!

anahas-redhat commented Nov 6, 2025

Uh oh!

anahas-redhat commented Nov 6, 2025

Uh oh!

MaysaMacedo Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

MaysaMacedo commented Nov 7, 2025

Uh oh!

kannon92 commented Nov 7, 2025

Uh oh!

openshift-cherrypick-robot commented Nov 7, 2025

Uh oh!

rphillips Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

MaysaMacedo left a comment

Choose a reason for hiding this comment

Uh oh!

MaysaMacedo Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

rphillips commented Nov 10, 2025

Uh oh!

openshift-ci bot commented Nov 10, 2025

Uh oh!

kannon92 commented Nov 10, 2025

Uh oh!

openshift-cherrypick-robot commented Nov 10, 2025

Uh oh!

openshift-ci bot commented Nov 10, 2025

Uh oh!

Uh oh!

openshift-cherrypick-robot commented Nov 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

anahas-redhat commented Nov 3, 2025 •

edited

Loading