Skip to content

operator/resourcesynccontroller/resourcesync_controller: add WithConditionPrefix #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

operator/resourcesynccontroller/resourcesync_controller: add WithConditionPrefix #2029

wants to merge 2 commits into from

Conversation

@p0lyn0mial
Copy link
Contributor

@p0lyn0mial p0lyn0mial commented Oct 2, 2025 

// WithConditionPrefix sets a prefix for the controller's condition types.
// This is useful when multiple operators reuse the same controller but would like to have
// distinct conditions.

@p0lyn0mial p0lyn0mial requested a review from benluddy October 2, 2025 14:38
@p0lyn0mial
Copy link
Contributor Author

p0lyn0mial commented Oct 2, 2025

/hold

for a proof pr in the operators.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2025
p0lyn0mial
p0lyn0mial commented Oct 2, 2025
View reviewed changes
pkg/operator/resourcesynccontroller/resourcesync_controller.go
// WithConditionPrefix sets a prefix for the controller's condition types.
// This is useful when multiple operators reuse the same controller but would like to have
// distinct conditions.
func (c *ResourceSyncController) WithConditionPrefix(prefix string) *ResourceSyncController {
Copy link
Contributor Author

@p0lyn0mial p0lyn0mial Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don’t want to change the instance name, so that there is only one manager.

Alternatively, we could add a new constructor that allows assigning a new prefix.

@openshift-ci openshift-ci bot requested review from bertinatto and jsafrane October 2, 2025 14:41
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

@p0lyn0mial: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benluddy benluddy Awaiting requested review from benluddy

@bertinatto bertinatto Awaiting requested review from bertinatto

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@p0lyn0mial