OLS-2092 Byok log enhancements #2664
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sriroopar
force-pushed
the
byok_log_enhancements
branch
from
3035f96 to
6775874
Compare
|
/retest |
5 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
#Reverting the storing changes
sriroopar
force-pushed
the
byok_log_enhancements
branch
from
e9c6284 to
b559dd8
Compare
|
/retest |
|
@sriroopar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
||
| available_tokens = min(tokens_count, max_tokens) | ||
| logger.debug("Available tokens: %d.", tokens_count) | ||
| logger.debug("Available tokens: %d.", available_tokens) |
There was a problem hiding this comment.
I supose this should show the total number of available tokens in the context window, but it is not showing that:
2025-11-19 08:03:01,970 [ols.utils.token_handler:token_handler.py:152] DEBUG: RAG content tokens count: 345.
2025-11-19 08:03:01,970 [ols.utils.token_handler:token_handler.py:155] DEBUG: Available tokens: 345.
2025-11-19 08:03:01,970 [ols.utils.token_handler:token_handler.py:169] INFO: Document #2 selected: title='Preparing your cluster for OpenShift Virtualization', url='https://docs.openshift.com/container-platform/4.17/virt/install/preparing-cluster-for-virt.html', index='default', score=0.5925, tokens=345
2025-11-19 08:03:01,971 [ols.utils.token_handler:token_handler.py:152] DEBUG: RAG content tokens count: 358.
2025-11-19 08:03:01,971 [ols.utils.token_handler:token_handler.py:155] DEBUG: Available tokens: 358.
2025-11-19 08:03:01,971 [ols.utils.token_handler:token_handler.py:169] INFO: Document #3 selected: title='Installing a cluster on any platform', url='https://docs.openshift.com/container-platform/4.17/installing/installing_platform_agnostic/installing-platform-agnostic.html', index='default', score=0.5889, tokens=358
It is showing the same number twice.
| """Initialize custom query fusion class.""" | ||
| # Extract custom parameters before passing to parent | ||
| retriever_weights = kwargs.pop("retriever_weights", None) | ||
| index_configs = kwargs.pop("index_configs", None) |
There was a problem hiding this comment.
Why pop instead of get? Do you need to modify input kwargs?
2 participants
Description
Added info logs to display information on document retrieved, indices, rank, score and the final document that's picked based on the metrics.
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing
Verified by running RAG test suite and logs were checked.