[DO NOT MERGE] Reboot noanno #5405
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add install time support for Image Mode by using a pre-built custom OS container image with the MachineOSConfig CR created at install time in the manifests directory. **Core Workflow:** 1. Bootstrap: Creates component MachineConfig (10-prebuiltimage-osimageurl-<pool>) that sets osImageURL from MOSC annotation 2. Cluster startup: Seeding workflow creates synthetic MachineOSBuild with success status 3. Post-install: Normal OCL workflows handle MC changes and image updates **Seeding Implementation:** - Annotation-driven detection in addMachineOSConfig() - seedMachineOSConfigWithExistingImage() orchestrates seeding workflow - createSyntheticMachineOSBuild() generates synthetic MOSB marked as successful - updateMachineOSConfigForSeeding() updates MOSC status and annotations - Adds "Seeded" condition and PreBuiltImageSeededAnnotationKey marker - PreBuiltImageAnnotationKey remains on MOSC for component MC management **Bootstrap Integration:** - Recognizes MachineOSConfig manifests during bootstrap processing - Creates component MachineConfigs that set osImageURL for each pool - Component MCs are merged into rendered MCs by render controller - Validates pre-built image format (requires digest @sha256:) **Operator Sync:** - syncPreBuiltImageMachineConfigs() manages component MC lifecycle - Creates/updates component MCs based on MOSC annotations - Deletes component MCs when annotation is removed from MOSC **Install-Time Guards:** - Handles empty MCP status.configuration.name during pool convergence - Skips rendered config comparison when status.configuration.name is empty - Prevents MachineConfig lookups with empty names at install time - Node controller uses current-machine-os-build annotation for MOSB lookup **Key Components:** - PreBuiltImageAnnotationKey: Triggers seeding, persists for component MC management - PreBuiltImageSeededAnnotationKey: Tracks seeding completion - PreBuiltImageLabelKey: Labels synthetic MachineOSBuilds - "Seeded" condition: Status indicator for successfully seeded MOSCs **Testing:** - Comprehensive unit tests for seeding workflow - Bootstrap test validation with example manifest - Tests for annotation detection and routing logic Signed-off-by: Urvashi <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Contributor
|
Skipping CI for Draft Pull Request. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
umohnani8
force-pushed
the
reboot-noanno
branch
2 times, most recently
from
414bb7a to
266c68a
Compare
Signed-off-by: Urvashi <[email protected]>
umohnani8
force-pushed
the
reboot-noanno
branch
from
266c68a to
d9e8943
Compare
openshift-merge-robot
added
the
needs-rebase
Contributor
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How to verify it
- Description for the changelog