MCO-1956: Stream image utils #5409
Conversation
openshift-ci
bot
added
the
approved
openshift-ci-robot
added
the
jira/valid-reference
|
@pablintino: This pull request references MCO-1956 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
pablintino
force-pushed
the
stream-image-utils
branch
from
2c321ce to
917ac74
Compare
|
/payload-job periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-aws-ipi-longduration-mco-p1-f7 periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-aws-ipi-longduration-mco-p2-f7 periodic-ci-openshift-openshift-tests-private-release-4.21-amd64-nightly-aws-ipi-longduration-mco-p3-f7 |
|
@sergiordlr: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ff8adf70-c149-11f0-9507-931dad5d84df-0 |
pablintino
force-pushed
the
stream-image-utils
branch
2 times, most recently
from
8c00de2 to
105549d
Compare
Add logic and tests that can be used to inspect and work with images. This code can be reused in multiple components, like the build controller or the future OSImageStream logic.
pablintino
force-pushed
the
stream-image-utils
branch
from
105549d to
a5812ee
Compare
isabella-janssen
left a comment
isabella-janssen
left a comment
There was a problem hiding this comment.
This generally looks good to me and I see that the new unit tests for it are passing. I'll give some time to the rest of the team to review, if they want, before tagging.
isabella-janssen
left a comment
isabella-janssen
left a comment
There was a problem hiding this comment.
/lgtm
Thanks @pablintino 🎉
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen, pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
verified
|
@pablintino: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/retest-required |
|
@pablintino: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/override ci/prow/e2e-gcp-op-single-node |
|
@pablintino: Overrode contexts on behalf of pablintino: ci/prow/e2e-gcp-op-single-node In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 participants
- What I did
Build common helpers to manipulate and work with images. The helpers have been introduced in the image builder to replace part of the logic and will be the base of the OSImageStream logic.
- How to verify it
Verified by the new test file
imageutils_test.go, part of e2e-2of2- Description for the changelog
Add container image utilities for file extraction and inspection with e2e tests