Add comprehensive test coverage for restore plugins #312
Conversation
kaovilai
commented
May 30, 2025
kaovilai
commented
- Add test files for all restore.go files that were missing tests
- Update existing test files to improve coverage:
- horizontalpodautoscaler: Add Execute() tests for all scenarios
- pod: Add tests for AppliesTo(), PodHasVolumesToBackUp(), and PodHasRestoreHookAnnotations()
- route: Add Execute() tests for route host generation scenarios
- Add documentation comments explaining where Execute() functionality is tested for plugins that only test AppliesTo()
- Fix failing tests by adjusting to match implementation behavior
openshift-ci
bot
added
the
approved
kaovilai
force-pushed
the
unit_tests
branch
2 times, most recently
from
10fbc8e to
c20f908
Compare
- Add test files for all restore.go files that were missing tests - Update existing test files to improve coverage: - horizontalpodautoscaler: Add Execute() tests for all scenarios - pod: Add tests for AppliesTo(), PodHasVolumesToBackUp(), and PodHasRestoreHookAnnotations() - route: Add Execute() tests for route host generation scenarios - Add documentation comments explaining where Execute() functionality is tested for plugins that only test AppliesTo() - Fix failing tests by adjusting to match implementation behavior
|
/cherry-pick oadp-1.5 oadp-1.4 |
|
@kaovilai: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/cherry-pick oadp-1.4 |
|
@kaovilai: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, shubham-pampattiwar, sseago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
/test all |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
