Skip to content

Upgrade golang to 1.25 for backplane-2.11 and main #72651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Dec 22, 2025
Merged

Upgrade golang to 1.25 for backplane-2.11 and main #72651

openshift-merge-bot merged 1 commit into from
Dec 22, 2025

Conversation

@haoqing0110
Copy link
Member

@haoqing0110 haoqing0110 commented Dec 16, 2025

Summary

Upgrade golang version to 1.25 for both backplane-2.11 and main branch across multiple repositories.

Changes

Update golang version from various versions (1.21, 1.23, 1.24) to 1.25 for:

  • ocm: backplane-2.11 (1.21→1.25) and main (1.21→1.25)
  • multicloud-operators-foundation: backplane-2.11 (1.24→1.25) and main (1.24→1.25)
  • managedcluster-import-controller: backplane-2.11 (1.24→1.25) and main (1.24→1.25)
  • managed-serviceaccount: backplane-2.11 (1.23→1.25) and main (1.23→1.25)
  • cluster-proxy: backplane-2.11 (1.23→1.25) and main (1.23→1.25)

Files Modified

Backplane-2.11 (5 files):

  • ci-operator/config/stolostron/ocm/stolostron-ocm-backplane-2.11.yaml
  • ci-operator/config/stolostron/multicloud-operators-foundation/stolostron-multicloud-operators-foundation-backplane-2.11.yaml
  • ci-operator/config/stolostron/managedcluster-import-controller/stolostron-managedcluster-import-controller-backplane-2.11.yaml
  • ci-operator/config/stolostron/managed-serviceaccount/stolostron-managed-serviceaccount-backplane-2.11.yaml
  • ci-operator/config/stolostron/cluster-proxy/stolostron-cluster-proxy-backplane-2.11.yaml

Main Branch (5 files):

  • ci-operator/config/stolostron/ocm/stolostron-ocm-main.yaml
  • ci-operator/config/stolostron/multicloud-operators-foundation/stolostron-multicloud-operators-foundation-main.yaml
  • ci-operator/config/stolostron/managedcluster-import-controller/stolostron-managedcluster-import-controller-main.yaml
  • ci-operator/config/stolostron/managed-serviceaccount/stolostron-managed-serviceaccount-main.yaml
  • ci-operator/config/stolostron/cluster-proxy/stolostron-cluster-proxy-main.yaml

🤖 Generated with Claude Code

@haoqing0110
Upgrade golang to 1.25 for backplane-2.11 and main
c471a9b 
Update golang version to 1.25 for both backplane-2.11 and main branch across:
- ocm (backplane-2.11: 1.21→1.25, main: 1.21→1.25)
- multicloud-operators-foundation (backplane-2.11: 1.24→1.25, main: 1.24→1.25)
- managedcluster-import-controller (backplane-2.11: 1.24→1.25, main: 1.24→1.25)
- managed-serviceaccount (backplane-2.11: 1.23→1.25, main: 1.23→1.25)
- cluster-proxy (backplane-2.11: 1.23→1.25, main: 1.23→1.25)

Files modified:
Backplane-2.11:
- ci-operator/config/stolostron/ocm/stolostron-ocm-backplane-2.11.yaml
- ci-operator/config/stolostron/multicloud-operators-foundation/stolostron-multicloud-operators-foundation-backplane-2.11.yaml
- ci-operator/config/stolostron/managedcluster-import-controller/stolostron-managedcluster-import-controller-backplane-2.11.yaml
- ci-operator/config/stolostron/managed-serviceaccount/stolostron-managed-serviceaccount-backplane-2.11.yaml
- ci-operator/config/stolostron/cluster-proxy/stolostron-cluster-proxy-backplane-2.11.yaml

Main:
- ci-operator/config/stolostron/ocm/stolostron-ocm-main.yaml
- ci-operator/config/stolostron/multicloud-operators-foundation/stolostron-multicloud-operators-foundation-main.yaml
- ci-operator/config/stolostron/managedcluster-import-controller/stolostron-managedcluster-import-controller-main.yaml
- ci-operator/config/stolostron/managed-serviceaccount/stolostron-managed-serviceaccount-main.yaml
- ci-operator/config/stolostron/cluster-proxy/stolostron-cluster-proxy-main.yaml

Signed-off-by: Qing Hao <[email protected]>
@openshift-ci openshift-ci bot requested review from elgnay and qiujian16 December 16, 2025 09:20
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 16, 2025

[REHEARSALNOTIFIER]
@haoqing0110: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stolostron-multicloud-operators-foundation-main-build stolostron/multicloud-operators-foundation presubmit Ci-operator config changed
pull-ci-stolostron-multicloud-operators-foundation-main-e2e stolostron/multicloud-operators-foundation presubmit Ci-operator config changed
pull-ci-stolostron-multicloud-operators-foundation-main-images stolostron/multicloud-operators-foundation presubmit Ci-operator config changed
pull-ci-stolostron-multicloud-operators-foundation-main-integration stolostron/multicloud-operators-foundation presubmit Ci-operator config changed
pull-ci-stolostron-multicloud-operators-foundation-main-pr-image-mirror stolostron/multicloud-operators-foundation presubmit Ci-operator config changed
pull-ci-stolostron-multicloud-operators-foundation-main-sonar-pre-submit stolostron/multicloud-operators-foundation presubmit Ci-operator config changed
pull-ci-stolostron-multicloud-operators-foundation-main-unit stolostron/multicloud-operators-foundation presubmit Ci-operator config changed
pull-ci-stolostron-multicloud-operators-foundation-main-verify stolostron/multicloud-operators-foundation presubmit Ci-operator config changed
pull-ci-stolostron-multicloud-operators-foundation-main-verify-deps stolostron/multicloud-operators-foundation presubmit Ci-operator config changed
pull-ci-stolostron-multicloud-operators-foundation-backplane-2.11-build stolostron/multicloud-operators-foundation presubmit Ci-operator config changed
pull-ci-stolostron-multicloud-operators-foundation-backplane-2.11-e2e stolostron/multicloud-operators-foundation presubmit Ci-operator config changed
pull-ci-stolostron-multicloud-operators-foundation-backplane-2.11-images stolostron/multicloud-operators-foundation presubmit Ci-operator config changed
pull-ci-stolostron-multicloud-operators-foundation-backplane-2.11-integration stolostron/multicloud-operators-foundation presubmit Ci-operator config changed
pull-ci-stolostron-multicloud-operators-foundation-backplane-2.11-pr-image-mirror stolostron/multicloud-operators-foundation presubmit Ci-operator config changed
pull-ci-stolostron-multicloud-operators-foundation-backplane-2.11-sonarcloud stolostron/multicloud-operators-foundation presubmit Ci-operator config changed
pull-ci-stolostron-multicloud-operators-foundation-backplane-2.11-unit stolostron/multicloud-operators-foundation presubmit Ci-operator config changed
pull-ci-stolostron-multicloud-operators-foundation-backplane-2.11-verify stolostron/multicloud-operators-foundation presubmit Ci-operator config changed
pull-ci-stolostron-multicloud-operators-foundation-backplane-2.11-verify-deps stolostron/multicloud-operators-foundation presubmit Ci-operator config changed
pull-ci-stolostron-ocm-backplane-2.11-e2e stolostron/ocm presubmit Ci-operator config changed
pull-ci-stolostron-ocm-backplane-2.11-images stolostron/ocm presubmit Ci-operator config changed
pull-ci-stolostron-ocm-backplane-2.11-integration stolostron/ocm presubmit Ci-operator config changed
pull-ci-stolostron-ocm-backplane-2.11-unit stolostron/ocm presubmit Ci-operator config changed
pull-ci-stolostron-ocm-backplane-2.11-verify stolostron/ocm presubmit Ci-operator config changed
pull-ci-stolostron-ocm-backplane-2.11-verify-deps stolostron/ocm presubmit Ci-operator config changed
pull-ci-stolostron-ocm-main-images stolostron/ocm presubmit Ci-operator config changed

A total of 55 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@haoqing0110
Copy link
Member Author

haoqing0110 commented Dec 18, 2025

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 18, 2025

@haoqing0110: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

@haoqing0110: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 18, 2025
@qiujian16
Copy link
Contributor

qiujian16 commented Dec 22, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 5977fbc into openshift:master Dec 22, 2025
18 checks passed
@haoqing0110 haoqing0110 deleted the upgrade-golang-1.25-backplane-2.11-and-main branch December 22, 2025 03:12
@dhaiducek dhaiducek mentioned this pull request Dec 22, 2025
Closed
@dhaiducek
Copy link
Contributor

dhaiducek commented Dec 22, 2025

I've opened a followup to this. The OCM image was being built with a UBI8 builder, so the bump to Go1.25 came with a UBI9 builder that creates binaries that are not compatible with the current UBI8 base image.

@dhaiducek
Copy link
Contributor

dhaiducek commented Dec 22, 2025

I've closed my PR. Looks like you've already got it handled! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elgnay elgnay Awaiting requested review from elgnay

@qiujian16 qiujian16 Awaiting requested review from qiujian16

Assignees

@qiujian16 qiujian16

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@haoqing0110 @openshift-ci-robot @qiujian16 @dhaiducek