Skip to content

Conversation

@niteeshkd
Copy link

This reverts commit ae16961.

Per Pei Zhang's request as this PR is causing the current CI setup fail.

This reverts commit ae16961.

Per Pei Zhang's request as this PR is causing the current CI setup fail.

Signed-off-by: Niteesh Dubey <[email protected]>
@openshift-ci openshift-ci bot requested review from pmores and wainersm October 15, 2025 15:06
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 15, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 15, 2025

Hi @niteeshkd. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@niteeshkd
Copy link
Author

@bpradipt @gkurz , I am reverting the PR which is causing some issue in the current setup while @pezhang is developing CI code.

case $tee_type in
tdx)
filepath=/etc/kata-containers/kata-tdx/config.d/96-kata-kernel-config
filepath=/etc/kata-containers/tdx/config.d/96-kata-kernel-config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ae16961 was aligning the script to use the same paths as the RPM for the kata configuration... why would we want to revert that ? Please share details on the error in CI @pezhang.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides ae16961, there are still several changes(eg: layered image updating #1230 ) are needed to make the scripts work. So I was thinking these changes can be made in 1 PR. Right now I can test by manually patching . So not a blocker for CI testing right now. So the revert is not necessary for testing and can be closed. Thank you. @gkurz @niteeshkd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants