Update operator sdk to 1.41.1 #1192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
needs-rebase
openshift-ci
bot
added
the
do-not-merge/work-in-progress
littlejawa
force-pushed
the
update_operator_sdk_to_1.41.1
branch
from
a60a2b0 to
5f6546b
Compare
openshift-merge-robot
removed
the
needs-rebase
littlejawa
force-pushed
the
update_operator_sdk_to_1.41.1
branch
from
5f6546b to
ff2424c
Compare
Contributor
Author
|
Note: 69dcc90 is breaking the build. Everything else seems to work - I have run "go mod tidy && make && make bundle" on every separate commit, and the generated files are not changing anymore. This kustomize issue is the last problem I need to fix. |
openshift-merge-robot
added
the
needs-rebase
littlejawa
force-pushed
the
update_operator_sdk_to_1.41.1
branch
from
ff2424c to
bd6c962
Compare
openshift-merge-robot
removed
the
needs-rebase
littlejawa
force-pushed
the
update_operator_sdk_to_1.41.1
branch
from
bd6c962 to
26ae3a5
Compare
openshift-merge-robot
added
the
needs-rebase
littlejawa
force-pushed
the
update_operator_sdk_to_1.41.1
branch
from
26ae3a5 to
200cb94
Compare
openshift-merge-robot
removed
the
needs-rebase
littlejawa
force-pushed
the
update_operator_sdk_to_1.41.1
branch
3 times, most recently
from
1a029f0 to
be2ea6b
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/unhold |
Contributor
Author
|
Fixes: KATA-3600 |
We get warnings about deprecated "patchesjson6902" when we run "make bundle". As suggested in the error message, I used "kustomize edit fix --vars" to update our kustomize.yaml files Signed-off-by: Julien Ropé <[email protected]>
Signed-off-by: Julien Ropé <[email protected]>
While updating the operator-sdk, I'm finding some code that is supposed to be modified during upgrade, but doesn't exist in our repo. This commit allows to configure health probe address instead of using the default. Found while looking at updates for operator-sdk 1.38 [0]. Code sample found in operator-sdk testdata sources [1]. [0] https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.38.0/ [1] https://github.com/operator-framework/operator-sdk/blob/master/testdata/go/v4/memcached-operator/cmd/main.go Signed-off-by: Julien Ropé <[email protected]>
While updating the operator-sdk, I'm finding some code that is supposed to be modified during upgrade, but doesn't exist in our repo. This commit allows to serve metrics using HTTPS instead of HTTP. It also disabled the HTTP2 method by default, to avoid some vulnerabilities. Found while looking at updates for operator-sdk 1.38 [0]. Code sample found in operator-sdk testdata sources [1]. [0] https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.38.0/ [1] https://github.com/operator-framework/operator-sdk/blob/master/testdata/go/v4/memcached-operator/cmd/main.go Signed-off-by: Julien Ropé <[email protected]>
Our upgrade to operator-sdk 1.38 was missing some changes. Based on https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.38.0/ Signed-off-by: Julien Ropé <[email protected]>
Our upgrade to operator-sdk 1.38 was missing some changes. Based on https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.39.0/ Signed-off-by: Julien Ropé <[email protected]>
…server Based on https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.40.0/#update-your-project-to-properly-support-tls-certificates-for-webhooks-and-metrics-server Signed-off-by: Julien Ropé <[email protected]>
1.41: Performing upgrade steps based on https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.41.0/ 1.41.1: no modification required Signed-off-by: Julien Ropé <[email protected]>
littlejawa
force-pushed
the
update_operator_sdk_to_1.41.1
branch
from
be2ea6b to
92a8f6a
Compare
|
@littlejawa: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating operator-sdk from 1.39.1 to 1.41.1.
Preliminary steps: adding some code that we are supposed to modify, but doesn't exist in our repo.
Also fixing some update steps that were missing in previous commits.
1.39.1 => 1.40: the number of changes is big, so I'm keeping each modification separated, based on the titles in https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.40.0/
1.40 => 1.41.1: doing it in a single commit as it is easier.