Skip to content

Conversation

@joelsmith
Copy link
Contributor

@joelsmith joelsmith commented Jul 23, 2025

Copy data from https://raw.githubusercontent.com/openshift/kubernetes-autoscaler/release-4.20/vertical-pod-autoscaler/deploy/vpa-v1-crd-gen.yaml to config/vpa/vpa-crd.yaml and config/vpa/vpacheckpoint-crd.yaml

Also update config/vpa/vpa-rbac.yaml

@openshift-ci openshift-ci bot requested review from jkyros and wangchen615 July 23, 2025 16:44
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2025
@joelsmith
Copy link
Contributor Author

This is also blocking #207 since it causes blocking CI tests to fail

@jkyros
Copy link
Member

jkyros commented Jul 23, 2025

That vpa-recommender-lease addition was weirding me out, but it matches upstream, they're doing a migration thing kubernetes/autoscaler#7498.

Makes sense, looks good. Thanks Joel!

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkyros, joelsmith

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b25fbf7 and 2 for PR HEAD fba6f7d in total

@jkyros
Copy link
Member

jkyros commented Jul 23, 2025

Pass rate is not amazing on that scorecard test, although max got a clean run on #206. It looks like hypershift is having trouble giving us a test node?

found","stacktrace":"github.com/openshift/hypershift/cmd/infra/aws.(*CreateInfraOptions).LookupPublicZone\n\t/hypershift/cmd/infra/aws/route53.go:26\ngithub.com/openshift/hypershift/cmd/infra/aws.(*CreateInfraOptions).CreateInfra\n\t/hypershift/cmd/infra/aws/create.go:326\ngithub.com/openshift/hypershift/cmd/cluster/aws.(*ValidatedCreateOptions).Complete\n\t/hypershift/cmd/cluster/aws/create.go:154\ngithub.com/openshift/hypershift/cmd/cluster/core.CreateCluster\n\t/hypershift/cmd/cluster/core/create.go:813\ngithub.com/openshift/hypershift/cmd/cluster/aws.NewCreateCommand.func1\n\t/hypershift/cmd/cluster/aws/create.go:490\ngithub.com/spf13/cobra.(*Command).execute\n\t/hypershift/vendor/github.com/spf13/cobra/command.go:985\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\t/hypershift/vendor/github.com/spf13/cobra/command.go:1117\ngithub.com/spf13/cobra.(*Command).Execute\n\t/hypershift/vendor/github.com/spf13/cobra/command.go:1041\ngithub.com/spf13/cobra.(*Command).ExecuteContext\n\t/hypershift/vendor/github.com/spf13/cobra/command.go:1034\nmain.main\n\t/hypershift/main.go:78\nruntime.main\n\t/usr/lib/golang/src/runtime/proc.go:272"}
{"level":"error","ts":"2025-07-23T19:39:01Z","msg":"Failed to create cluster","error":"could not complete platform specific options: failed to create infra: hosted zone hypershift.origin-ci-int-aws.dev.rhcloud.com not found","stacktrace":"github.com/openshift/hypershift/cmd/cluster/aws.NewCreateCommand.func1\n\t/hypershift/cmd/cluster/aws/create.go:491\ngithub.com/spf13/cobra.(*Command).execute\n\t/hypershift/vendor/github.com/spf13/cobra/command.go:985\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\t/hypershift/vendor/github.com/spf13/cobra/command.go:1117\ngithub.com/spf13/cobra.(*Command).Execute\n\t/hypershift/vendor/github.com/spf13/cobra/command.go:1041\ngithub.com/spf13/cobra.(*Command).ExecuteContext\n\t/hypershift/vendor/github.com/spf13/cobra/command.go:1034\nmain.main\n\t/hypershift/main.go:78\nruntime.main\n\t/usr/lib/golang/src/runtime/proc.go:272"}
Error: could not complete platform specific options: failed to create infra: hosted zone hypershift.origin-ci-int-aws.dev.rhcloud.com not found
could not complete platform specific options: failed to create infra: hosted zone hypershift.origin-ci-int-aws.dev.rhcloud.com not found
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2025-07-23T19:39:01Z"}
error: failed to execute wrapped command: exit status 1 

I don't know that scorecard is super important, will skip if you want.

@joelsmith
Copy link
Contributor Author

/test scorecard

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b25fbf7 and 2 for PR HEAD fba6f7d in total

@jkyros
Copy link
Member

jkyros commented Jul 24, 2025

Something is wrong in infrastructure with that hypershift workflow step we use for the test, we'll have to dig into that later.
/override ci/prow/scorecard

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

@jkyros: Overrode contexts on behalf of jkyros: ci/prow/scorecard

In response to this:

Something is wrong in infrastructure with that hypershift workflow step we use for the test, we'll have to dig into that later.
/override ci/prow/scorecard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

@joelsmith: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ab1dc95 into openshift:main Jul 24, 2025
14 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: vertical-pod-autoscaler-operator
This PR has been included in build ose-vertical-pod-autoscaler-operator-container-v4.20.0-202507242313.p0.gab1dc95.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants