-
Notifications
You must be signed in to change notification settings - Fork 34
Update CRDs & RBAC to match operand #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is also blocking #207 since it causes blocking CI tests to fail |
|
That Makes sense, looks good. Thanks Joel! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkyros, joelsmith The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Pass rate is not amazing on that scorecard test, although max got a clean run on #206. It looks like hypershift is having trouble giving us a test node? I don't know that scorecard is super important, will skip if you want. |
|
/test scorecard |
|
Something is wrong in infrastructure with that hypershift workflow step we use for the test, we'll have to dig into that later. |
|
@jkyros: Overrode contexts on behalf of jkyros: ci/prow/scorecard In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@joelsmith: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: vertical-pod-autoscaler-operator |
Copy data from
https://raw.githubusercontent.com/openshift/kubernetes-autoscaler/release-4.20/vertical-pod-autoscaler/deploy/vpa-v1-crd-gen.yamltoconfig/vpa/vpa-crd.yamlandconfig/vpa/vpacheckpoint-crd.yamlAlso update
config/vpa/vpa-rbac.yaml