Fixed prerendering again #2631
Merged
Fixed prerendering again #2631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wait for all tasks
Dantemss
changed the title
Member
Author
|
4 GB per prerendering task seems enough to prevent workers from getting oomkilled. |
TomWoodward
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/CORE-771
Prerendering was being inefficient for large instances because the daemon strategy only creates one task per instance.
The replica stategy (the default) requires a desiredCount of tasks.
After changing that, the stack was failing to create because it was waiting for all 256 tasks to start.
So instead we start with 1 task, then scale it after the stack is created, so the stack creation doesn't get stuck waiting for all tasks to be created.
This required adding a new ecs:UpdateService permission to concourse.
While deploying that, it also deployed an old change that was already merged that changed the project tag that concourse is allowed to put on the stack from Unified to DISCO.
So that changed here as well.