Remove deprecated TSLint from project #2637
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSLint has been deprecated since 2019 and is no longer maintained. All linting is now handled exclusively by ESLint. Changes: - Removed tslint package from devDependencies - Removed tslint.json configuration file - Updated lint:typescript script to remove tslint command - Removed tslint.json mount from docker-compose.yml ESLint continues to provide comprehensive TypeScript linting via the react-app configuration. Related to CORE-1458 (tooling modernization) and CORE-1459 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Adds comma-dangle and space-before-function-paren rules to .eslintrc to maintain the code style that was previously enforced by TSLint. Rules added: - comma-dangle: Requires trailing commas in multiline arrays/objects, but not in function parameters (matches TSLint config) - space-before-function-paren: No space before function parentheses (matches TSLint config) These rules ensure consistent code formatting now that TSLint has been removed from the project. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
TomWoodward
had a problem deploying
to
rex-web-core-1459-remov-a27bcz
Removed 831 TSLint directive comments from 261 files across the codebase, including both standalone comment lines and inline comments. This cleanup follows the removal of the deprecated TSLint package. These comments are now obsolete since all linting is handled by ESLint. Changes: - Removed standalone TSLint directive comments (e.g., // tslint:disable-next-line:no-console) - Removed inline TSLint comments while preserving code (e.g., code; // tslint:disable-line:rule) - Updated script/add-page-map.ts to not generate TSLint comments in output files All code logic remains unchanged - only comments were removed. Related to CORE-1459 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
TomWoodward
had a problem deploying
to
rex-web-core-1459-remov-a27bcz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the deprecated TSLint package and configuration from rex-web. All TypeScript linting is now handled exclusively by ESLint.
Changes Made
devDependenciesin package.jsontslint -p ./tsconfig.jsoncommandWhy This Change?
TSLint has been deprecated since 2019 and is no longer maintained. The TypeScript team officially recommends using ESLint for TypeScript projects.
Impact
react-appconfigurationTesting
The
lint:typescriptscript now runs:eslint src && tscThis still provides:
Note on Inline Comments
There are TSLint disable comments in the codebase (e.g.,
// tslint:disable:no-console). These are harmless and will simply be ignored. They can be cleaned up in a future PR if desired, but they don't affect functionality.Related Issues
🤖 Generated with Claude Code