sample regression

[dmihalcik-virtru]

DO NOT MERGE

[gemini-code-assist]

Summary of Changes

Hello @dmihalcik-virtru, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, titled 'sample regression' and marked 'DO NOT MERGE', appears to be a test or draft. The sole change involves a minor adjustment to a boolean assignment within the Config.java file, specifically inverting the logic for hexEncodeRootAndSegmentHashes based on the legacyTDF flag. This modification likely serves to test a specific configuration behavior rather than introduce a functional change intended for production.

Highlights

• Configuration Logic Change: The logic for hexEncodeRootAndSegmentHashes in Config.java has been inverted. Previously, it was set to legacyTDF, and now it is set to !legacyTDF.
• Pull Request Status: This pull request is explicitly marked with 'DO NOT MERGE' in its description, indicating it is likely a sample or test PR.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a regression in the withTargetMode configuration method. The logic for determining whether to hex-encode root and segment hashes has been inverted, which contradicts the documented behavior for legacy TDF versions and will likely break existing tests. I have provided a comment with a suggested fix to restore the correct logic.

[gemini-code-assist]

This change appears to introduce a bug by inverting the logic for hexEncodeRootAndSegmentHashes.

According to the comment on line 318, TDF versions less than 4.3.0 (i.e., legacyTDF = true) should have hex encoding enabled. With this change, hexEncodeRootAndSegmentHashes is set to !legacyTDF. This means:

• For legacy TDFs (legacyTDF = true), hex encoding will be disabled (false).
• For modern TDFs (legacyTDF = false), hex encoding will be enabled (true).

This is the opposite of the intended behavior and will likely cause the withCompatibilityModeShouldSetFieldsCorrectly test in ConfigTest.java to fail. The original logic was correct and should be restored.

Suggested change

	config.hexEncodeRootAndSegmentHashes = !legacyTDF;
	config.hexEncodeRootAndSegmentHashes = legacyTDF;