Skip to content

Conversation

@BrennisC
Copy link
Contributor

@BrennisC BrennisC commented May 10, 2025

Cambios realizados

Este cambio permite mantener los datos del sitio actualizados de manera más dinámica y colaborativa, sin necesidad de modificar el código fuente directamente.

@netlify
Copy link

netlify bot commented May 10, 2025

👷 Deploy request for opentech pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c954027

@BrennisC BrennisC changed the title Feature: migración de datos estáticos a Google Sheets Feature: Migrating static data to Google Sheets May 10, 2025
@JimmyLoloy98 JimmyLoloy98 requested a review from Copilot June 15, 2025 17:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the static event data to a dynamic source by fetching event data from a Google Sheets CSV, while also updating some of the navigation links.

  • Migrated previous events to be fetched via event_api.list() in getStaticProps
  • Updated styling of buttons and SVG sizes for improved layout
  • Swapped GitHub and LinkedIn links on the homepage

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pages/previous-events.js Replaced static event import with dynamic data fetching via event_api.list(), and updated layout.
pages/index.js Modified navigation links to swap GitHub and LinkedIn references and adjusted button texts accordingly.
Comments suppressed due to low confidence (1)

pages/previous-events.js:5

  • Consider adding error handling for event_api.list() in getStaticProps to manage potential fetch failures gracefully.
const events = await event_api.list();

@JimmyLoloy98 JimmyLoloy98 self-requested a review June 15, 2025 17:11
Copy link
Member

@JimmyLoloy98 JimmyLoloy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahí te dejé un comentario de mejorar, para el código propuesto.
Por lo demás, está genial tu propuesta. 💎

if (!events) {
return <ErrorPage statusCode={404} />;
}
export async function getStaticProps() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por aqui, te sugiero que agregues un manejo de errores. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants