Support 3D Weights in AWQ Algorithm #3728
Open
+487
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NNCF OpenVINO
github-actions
bot
removed
NNCF OpenVINO
anzr299
force-pushed
the
an/3d_weights_awq
branch
from
a48b801 to
3122842
Compare
…nto an/3d_weights_awq
github-actions
bot
added
NNCF OpenVINO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The core idea of this change is to first unsqueeze the weights so that it becomes 3D. Even the 2D weights. Then the rest of the algorithm implementation is changed such that it expects the weight shape to be 3D.
Earlier we traversed each group in a weight individually. But now Since we want to find the scales for per-channel as well as per-expert, we traverse by group index as well as batch/expert index (this is just 1 for 2D weights so the behavior is same as before).
Reason for changes
Support AWQ for models with 3D weights such as MoE models.
Related tickets
175789 & 175212
Tests
Current AWQ tests were extended to include the AWQ test models with 3D weights.
Examples Test - 465 - Pass
WC Conformance - 187 - Pass