-
Notifications
You must be signed in to change notification settings - Fork 310
Apply whitespaces and new lines linting #3113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR applies whitespace and newline linting across the project by removing trailing blank lines from various files. The changes are purely formatting-related, executed via pre-commit run --all-files, with prompts in llm_bench excluded from linting.
Key Changes
- Removed trailing blank lines at the end of files across Python, C++, C, Markdown, and YAML files
- Added exclusion pattern for
tools/llm_bench/prompts/to the pre-commit configuration
Reviewed changes
Copilot reviewed 22 out of 145 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/cacheviz/cacheviz.py | Removed 3 trailing blank lines |
| tools/cacheviz/init.py | Removed 1 trailing blank line |
| tests/python_tests/test_llm_pipeline.py | Removed 1 trailing blank line |
| tests/python_tests/samples/test_speculative_decoding_lm.py | Removed 1 trailing blank line |
| tests/python_tests/samples/test_react_sample.py | Removed 1 trailing blank line |
| tests/python_tests/samples/test_prompt_lookup_decoding_lm.py | Removed 1 trailing blank line |
| tests/python_tests/samples/test_image2image.py | Removed 1 trailing blank line |
| tests/python_tests/samples/test_compound_grammar_sample.py | Removed 1 trailing blank line |
| tests/cpp/speculative_decoding.cpp | Removed 1 trailing blank line |
| tests/cpp/scheduler.cpp | Removed 2 trailing blank lines |
| tests/cpp/logit_filtering.cpp | Removed 1 trailing blank line |
| src/python/py_perf_metrics.cpp | Removed 1 trailing blank line |
| src/cpp/src/continuous_batching/cache_eviction.cpp | Removed 1 trailing blank line |
| src/cpp/include/openvino/genai/cache_eviction.hpp | Removed 1 trailing blank line |
| site/docs/use-cases/speech-generation/_sections/_run_model/index.mdx | Removed 1 trailing blank line |
| samples/python/text_generation/limit_checker.py | Removed 1 trailing blank line |
| samples/c/visual_language_chat/load_image.c | Removed 1 trailing blank line |
| samples/c/visual_language_chat/CMakeLists.txt | Removed 1 trailing blank line |
| samples/c/text_generation/README.md | Removed 1 trailing blank line |
| samples/c/text_generation/CMakeLists.txt | Removed 1 trailing blank line |
| .pre-commit-config.yaml | Added exclusion for llm_bench prompts directory |
| .github/workflows/sdl.yml | Removed 1 trailing blank line |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 28 out of 150 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 28 out of 149 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@sgonorov Did you check current ruff behavior? Is it expected that not only whitespaces and newlines are litned? |
Description
PR with linting changes only. The whole project was lint with:
pre-commit run --all-filesExclude was extended with tools prompts:
Checklist: