Skip to content

Conversation

@as-suvorov
Copy link
Collaborator

@as-suvorov as-suvorov commented Dec 12, 2025

Description

PR with linting changes only. The whole project was lint with:
pre-commit run --all-files
Exclude was extended with tools prompts:

exclude: |
  (?x)(
    \.pyi$|
    ^tools/llm_bench/prompts/|
    ^tools/who_what_benchmark/whowhatbench/prompts/
  )

Checklist:

  • Tests have been updated or added to cover the new code.
  • This patch fully addresses the ticket.
  • I have made corresponding changes to the documentation.

Copilot AI review requested due to automatic review settings December 12, 2025 14:47
@github-actions github-actions bot added category: llm_bench Label for tool/llm_bench folder category: WWB PR changes WWB category: image generation Image generation pipelines category: visual language Visual language pipeline category: continuous batching Continuous batching category: LLM LLM pipeline (stateful, static) category: sampling Sampling / Decoding algorithms category: speculative decoding Speculative decoding category: LoRA Low rank adapters category: GHA CI based on Github actions category: cmake / build Cmake scripts category: Python API Python API for GenAI category: LLM samples GenAI LLM samples category: CPP API Changes in GenAI C++ public headers no-match-files category: GH Pages Docs Github Pages documentation category: GGUF GGUF file reader category: JS API GenAI JS API category: Whisper samples GenAI Whisper samples category: Image generation samples GenAI Image generation samples category: VLM samples GenAI VLM samples labels Dec 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies whitespace and newline linting across the project by removing trailing blank lines from various files. The changes are purely formatting-related, executed via pre-commit run --all-files, with prompts in llm_bench excluded from linting.

Key Changes

  • Removed trailing blank lines at the end of files across Python, C++, C, Markdown, and YAML files
  • Added exclusion pattern for tools/llm_bench/prompts/ to the pre-commit configuration

Reviewed changes

Copilot reviewed 22 out of 145 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/cacheviz/cacheviz.py Removed 3 trailing blank lines
tools/cacheviz/init.py Removed 1 trailing blank line
tests/python_tests/test_llm_pipeline.py Removed 1 trailing blank line
tests/python_tests/samples/test_speculative_decoding_lm.py Removed 1 trailing blank line
tests/python_tests/samples/test_react_sample.py Removed 1 trailing blank line
tests/python_tests/samples/test_prompt_lookup_decoding_lm.py Removed 1 trailing blank line
tests/python_tests/samples/test_image2image.py Removed 1 trailing blank line
tests/python_tests/samples/test_compound_grammar_sample.py Removed 1 trailing blank line
tests/cpp/speculative_decoding.cpp Removed 1 trailing blank line
tests/cpp/scheduler.cpp Removed 2 trailing blank lines
tests/cpp/logit_filtering.cpp Removed 1 trailing blank line
src/python/py_perf_metrics.cpp Removed 1 trailing blank line
src/cpp/src/continuous_batching/cache_eviction.cpp Removed 1 trailing blank line
src/cpp/include/openvino/genai/cache_eviction.hpp Removed 1 trailing blank line
site/docs/use-cases/speech-generation/_sections/_run_model/index.mdx Removed 1 trailing blank line
samples/python/text_generation/limit_checker.py Removed 1 trailing blank line
samples/c/visual_language_chat/load_image.c Removed 1 trailing blank line
samples/c/visual_language_chat/CMakeLists.txt Removed 1 trailing blank line
samples/c/text_generation/README.md Removed 1 trailing blank line
samples/c/text_generation/CMakeLists.txt Removed 1 trailing blank line
.pre-commit-config.yaml Added exclusion for llm_bench prompts directory
.github/workflows/sdl.yml Removed 1 trailing blank line

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added the category: whisper Whisper pipeline label Dec 15, 2025
Copilot AI review requested due to automatic review settings December 15, 2025 11:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 150 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 149 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@as-suvorov as-suvorov requested a review from sbalandi December 15, 2025 11:51
@as-suvorov
Copy link
Collaborator Author

@sgonorov Did you check current ruff behavior? Is it expected that not only whitespaces and newlines are litned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: C API category: cmake / build Cmake scripts category: continuous batching Continuous batching category: CPP API Changes in GenAI C++ public headers category: GGUF GGUF file reader category: GH Pages Docs Github Pages documentation category: GHA CI based on Github actions category: Image generation samples GenAI Image generation samples category: image generation Image generation pipelines category: JS API GenAI JS API category: llm_bench Label for tool/llm_bench folder category: LLM samples GenAI LLM samples category: LLM LLM pipeline (stateful, static) category: LoRA Low rank adapters category: Python API Python API for GenAI category: samples dependencies category: sampling Sampling / Decoding algorithms category: speculative decoding Speculative decoding category: Speech generation samples category: visual language Visual language pipeline category: VLM samples GenAI VLM samples category: Whisper samples GenAI Whisper samples category: whisper Whisper pipeline category: WWB PR changes WWB no-match-files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant