Skip to content

Conversation

@alexey-varyzgin
Copy link
Contributor

@alexey-varyzgin alexey-varyzgin commented Apr 1, 2022

Details:

  • bf16_ref_pooling from oneDNN was included
  • InputMemory and OutputMemory were adjusted by FP32 precision
  • Deconvolution fusing with FakeQuantize was disabled
  • Deconvolution function and fusing precision inconsistence was resolved

oneDNN related PR: openvinotoolkit/oneDNN#124

Tickets:

  • 83170

@alexey-varyzgin alexey-varyzgin requested review from a team April 1, 2022 10:13
@openvino-pushbot openvino-pushbot added the category: CPU OpenVINO CPU plugin label Apr 1, 2022
}

/**
* @todo FQ fusing was disabled for BF16 output since oneDNN primitives lack support
Copy link
Contributor

@EgorDuplensky EgorDuplensky Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add few words about motivation for Deconvolution?

@dmitry-gorokhov
Copy link

@alexey-varyzgin I think we should extend test coverage. At least Pooling and Deconvolution cases should be covered by tests to prevent such issues in future.

@dmitry-gorokhov dmitry-gorokhov modified the milestones: 2022.2, 2022.3 Aug 18, 2022
@dmitry-gorokhov dmitry-gorokhov removed this from the 2022.3 milestone Nov 16, 2022
@akladiev
Copy link
Collaborator

This PR will be closed in 2 weeks in case of no activity.

@akladiev akladiev added the Stale label May 11, 2023
@akladiev
Copy link
Collaborator

This PR was closed because it has been stalled for 2 week with no activity.

@akladiev akladiev closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: CPU OpenVINO CPU plugin Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants