-
-
Notifications
You must be signed in to change notification settings - Fork 99
[fix] Added default leaflet map option worldCopyJump: true to LeafletCoordSys
#459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nemesifier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a simple test which asserts that this worldCopyJump option is set to true?
This will protect us from the possibility that someone removes this by mistake in the future.
|
While running all tests, a couple of existing browser tests failed — for example:
My new test passes successfully and confirms that Could you please confirm if these browser tests are known issues, or should I look into them further? |
worldCopyJump: true to LeafletCoordSys
nemesifier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll just rename the test file for consistency.
nemesifier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon closer inspection, I see there's a test which is failing for real (not a false positive).
|
I am leaning towards a simpler approach, see #466. Thanks for contributing! |
|
Thanks for the feedback! |

Hi @nemesifier
This PR improves how map options are initialized in
LeafletCoordSys.create.It now creates a new object starting with a default
{ worldCopyJump: true }and then applies or overrides any user-provided settings.This helps ensure better user experience when panning across ±180° longitude (antimeridian) by enabling
worldCopyJumpby default.worldCopyJump.webm