Skip to content

Conversation

@stangri
Copy link
Member

@stangri stangri commented Aug 12, 2025

Derived from this: #7867

@stangri
Copy link
Member Author

stangri commented Aug 22, 2025

requesting more reviewers as I very infrequently open PRs against core components and definitely do not want to merge it myself, as little of a change as it is.

@hnyman
Copy link
Contributor

hnyman commented Aug 23, 2025

I use the default Bootstrap theme, so I haven't noticed the whole reset button issue at login there.
And to be honest, the original button order thing/discussion in the other PR seemed funny. Personally I have no clear preference for the button order. Well, maybe I would prefer first the positive "ok", then "cancel"...

@jow- is maybe the authority here, who also knows the possible fallout possibilities from the ucode change that you are proposing.

@stangri
Copy link
Member Author

stangri commented Aug 23, 2025

I use the default Bootstrap theme, so I haven't noticed the whole reset button issue at login there. And to be honest, the original button order thing/discussion in the other PR seemed funny. Personally I have no clear preference for the button order. Well, maybe I would prefer first the positive "ok", then "cancel"...

So the original discussion had screenshots that in the firmware update WebUI pages the "action" (Upload, Update) button was on the right and the cancel button on the left, contradicting your preference.

@jow- is maybe the authority here, who also knows the possible fallout possibilities from the ucode change that you are proposing.

Yeah, I can also patch the themes instead but if it is fixed in ucode it might give a clearer direction to theme creators/maintainers. But consensus in a previous PR was that the reset button is unneeded and is disabled in most themes anyways.

@stangri
Copy link
Member Author

stangri commented Oct 8, 2025

Unless there are objections, I'll merge this by mid-October.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants