strongswan: Add support for EAP-TLS authentication #27735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for configuring EAP-TLS authentication scheme is added. Similar to EAP-MSCHAPv2, this one is usually asymmetric in the way that server auth method (pubkey) is different from the client auth method (eap-tls). The code handles this asymmetry automatically. Signed-off-by: Torbjørn Tyridal <[email protected]> Signed-off-by: Torbjorn Tyridal <[email protected]>
pprindeville
requested changes
Nov 1, 2025
net/strongswan/files/swanctl.init
Outdated
|
|
||
| local local_auth_method="$auth_method" | ||
| [ "$auth_method" = "eap-mschapv2" ] && local_auth_method="pubkey" | ||
| [ "$auth_method" = "eap-tls" ] && local_auth_method="pubkey" |
There was a problem hiding this comment.
Please combine these lines.
There was a problem hiding this comment.
like this?
[ "$auth_method" = "eap-mschapv2" ] || [ "$auth_method" = "eap-tls" ] && local_auth_method="pubkey"
starting to look like a code-smell, if you ask me - but I'm not that used to bash coding.🙈
net/strongswan/files/swanctl.init
Outdated
| [ -n "$remote_identifier" ] && swanctl_xappend3 "id = \"$remote_identifier\"" | ||
| [ -n "$remote_ca_certs" ] && swanctl_xappend3 "cacerts = \"$remote_ca_certs\"" | ||
| [ "$auth_method" = eap-mschapv2 ] && swanctl_xappend3 "eap_id = $eap_id" | ||
| [ "$auth_method" = eap-tls ] && swanctl_xappend3 "eap_id = $eap_id" |
Signed-off-by: Torbjorn Tyridal <[email protected]>
GeorgeSapkin
requested changes
Nov 3, 2025
| [ -n "$remote_identifier" ] && swanctl_xappend3 "id = \"$remote_identifier\"" | ||
| [ -n "$remote_ca_certs" ] && swanctl_xappend3 "cacerts = \"$remote_ca_certs\"" | ||
| [ "$auth_method" = eap-mschapv2 ] && swanctl_xappend3 "eap_id = $eap_id" | ||
| [ "$auth_method" = "eap-mschapv2" ] || [ "$auth_method" = "eap-tls" ] && swanctl_xappend3 "eap_id = $eap_id" |
There was a problem hiding this comment.
Although AFAICT this is correct, there are a few alternatives to make this less ambiguous:
Suggested change
| [ "$auth_method" = "eap-mschapv2" ] || [ "$auth_method" = "eap-tls" ] && swanctl_xappend3 "eap_id = $eap_id" | |
| if [ "$auth_method" = "eap-mschapv2" ] || [ "$auth_method" = "eap-tls" ]; then | |
| swanctl_xappend3 "eap_id = $eap_id" | |
| fi |
or:
Suggested change
| [ "$auth_method" = "eap-mschapv2" ] || [ "$auth_method" = "eap-tls" ] && swanctl_xappend3 "eap_id = $eap_id" | |
| case "$auth_method" in | |
| eap-mschapv2 | eap-tls) | |
| swanctl_xappend3 "eap_id = $eap_id" | |
| ;; | |
| esac |
or:
Suggested change
| [ "$auth_method" = "eap-mschapv2" ] || [ "$auth_method" = "eap-tls" ] && swanctl_xappend3 "eap_id = $eap_id" | |
| [[ "$auth_method" = "eap-mschapv2" || "$auth_method" = "eap-tls" ]] && swanctl_xappend3 "eap_id = $eap_id" |
This applies to the other case as well.
There was a problem hiding this comment.
Actually, I don't think ash/Busybox supports [[ but I could be wrong... Try it. Otherwise use { ... } for grouping like:
{ [ "$auth_method" = "eap-mschapv2" ] || [ "$auth_method" = "eap-tls" ] } && swanctl_xappend3 "eap_id = $eap_id"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for configuring EAP-TLS authentication scheme is added.
Required for certificate authenticated road warriors on clients that don't support pubkey (Windows, MacOS, probably more)
Maintainer: @pprindeville
Runtested: 24.10.2