[XProf: trace viewer] Pre-calculate visible level offsets in Timeline. #2068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a `visible_level_offsets_` vector to store the y-offset for each level that is visually rendered. This allows for different rendering heights for different group types, such as flame charts and counters. The `CalculateOffsets` function now populates both group and visible level offsets. The event drawing logic is updated to use these pre-calculated offsets for positioning events. This will be used in the navigate to event feature. There is no visual change after this CL PiperOrigin-RevId: 845084690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[XProf: trace viewer] Pre-calculate visible level offsets in Timeline.
This change introduces a
visible_level_offsets_vector to store the y-offset for each level that is visually rendered. This allows for different rendering heights for different group types, such as flame charts and counters. TheCalculateOffsetsfunction now populates both group and visible level offsets. The event drawing logic is updated to use these pre-calculated offsets for positioning events.This will be used in the navigate to event feature.
There is no visual change after this CL