Skip to content

Conversation

@robn
Copy link
Member

@robn robn commented Nov 5, 2025

[Sponsors: Klara, Inc., Wasabi Technology, Inc.]

Motivation and Context

We've heard anecdotes that suggest some confusion/surprise/disappointment that a changed recordsize is not applied during rewrite. Until such time as we actually can do that, we can at least explicitly mention it at something that doesn't work.

Description

Another paragraph in the NOTES part of zfs-rewrite(8), describing vaguely what rewrite is, and from there, specific property changes that are and aren't applied.

How Has This Been Tested?

Manpage change, so just mancheck.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@robn robn force-pushed the man-zfs-rewrite-recordsize branch from 70e0e02 to a2b8589 Compare November 5, 2025 01:34
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Nov 5, 2025
We've heard anecdotes that suggest some
confusion/surprise/disappointment that a changed recordsize is not
applied during rewrite. Until such time as we actually can do that, we
can at least explicitly mention it at something that doesn't work.

Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Signed-off-by: Rob Norris <[email protected]>
@robn robn force-pushed the man-zfs-rewrite-recordsize branch from a2b8589 to 3c736d3 Compare November 6, 2025 22:45
@github-actions github-actions bot removed the Status: Accepted Ready to integrate (reviewed, tested) label Nov 6, 2025
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Nov 7, 2025
@amotin amotin merged commit 336c953 into openzfs:master Nov 7, 2025
19 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Accepted Ready to integrate (reviewed, tested)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants