improve: complete comparable resource version configs #3027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
metacosm
changed the title
xstefank
approved these changes
Nov 3, 2025
Collaborator
xstefank
left a comment
xstefank
left a comment
There was a problem hiding this comment.
Functionally OK, but I just want to say that 5.3 might contain quite a lot breaking changes so maybe we should reconsider if it should be a minor release if that's so.
shawkins
approved these changes
Nov 3, 2025
Collaborator
shawkins
left a comment
shawkins
left a comment
There was a problem hiding this comment.
LGTM, I wasn't quite sure where some of this would land.
The other thang to add would be to expand the message somewhere when a non-comparable exception occurs to let people know to turn off the setting.
metacosm
requested changes
Nov 3, 2025
...r-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/Informer.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerConfiguration.java
Show resolved
Hide resolved
| * @param value true if internal algorithms can use metadata.resourceVersion as a numeric value. | ||
| * @return this | ||
| */ | ||
| @Deprecated(forRemoval = true) |
Collaborator
There was a problem hiding this comment.
Not sure we can remove this method, yet.
Collaborator
Author
There was a problem hiding this comment.
It is not used anywhere anymore, so I would say it is better to remove to avoid confusion.
Signed-off-by: Attila Mészáros <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.