Updating file name input validation rule to give warning for dollar characters #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Achal1607
requested changes
Nov 7, 2025
patches/7893-draft.diff
Outdated
| + client.showMessage(new MessageParams(MessageType.Error,Bundle.ERR_InvalidObjectName(name))); | ||
| + return client.showInputBox(new ShowInputBoxParams(Bundle.CTL_TemplateUI_SelectName(), desc.getProposedName())).thenCompose(this); | ||
| + } else if (name.contains("$")) { | ||
| + final MessageActionItem continue_action = new MessageActionItem("Continue"); |
Member
There was a problem hiding this comment.
Please add it in the bundle so that it can be localized.
patches/7893-draft.diff
Outdated
| + return client.showInputBox(new ShowInputBoxParams(Bundle.CTL_TemplateUI_SelectName(), desc.getProposedName())).thenCompose(this); | ||
| + } else if (name.contains("$")) { | ||
| + final MessageActionItem continue_action = new MessageActionItem("Continue"); | ||
| + final MessageActionItem try_again = new MessageActionItem("Try Again"); |
Member
There was a problem hiding this comment.
Please add it in the bundle so that it can be localized.
patches/7893-draft.diff
Outdated
| + final MessageActionItem continue_action = new MessageActionItem("Continue"); | ||
| + final MessageActionItem try_again = new MessageActionItem("Try Again"); | ||
| + ShowMessageRequestParams smrp = new ShowMessageRequestParams(Arrays.asList(continue_action, try_again)); | ||
| + smrp.setMessage("Object name contains $, not recommended for user defined objects , Do you want to continue with the current name or try again ?"); |
Member
There was a problem hiding this comment.
Please add it in the bundle so that it can be localized.
sid-srini
reviewed
Nov 7, 2025
patches/7893-draft.diff
Outdated
Comment on lines
128
to
129
| + final MessageActionItem continue_action = new MessageActionItem("Continue"); | ||
| + final MessageActionItem try_again = new MessageActionItem("Try Again"); |
Member
There was a problem hiding this comment.
nit: Try to use the camel-case codestyle for naming variables etc.
shivam71
force-pushed
the
dollar_warning
branch
from
f162935 to
ca1042e
Compare
shivam71
force-pushed
the
dollar_warning
branch
from
ca1042e to
80ed7e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dollar characters are allowed for java objects but are not recommended for user defined objects this adds a check for the same .