Skip to content

Conversation

@supersonicbyte
Copy link
Collaborator

Description

Drop dependency on MacroTesting since our tests don't depend on it anymore.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Minimal checklist:

  • I have performed a self-review of my own code
  • I have added DocC code-level documentation for any public interfaces exported by the package
  • I have added unit and/or integration tests that prove my fix is effective or that my feature works

@supersonicbyte supersonicbyte requested a review from hassila July 29, 2025 08:35
@supersonicbyte supersonicbyte self-assigned this Jul 29, 2025
@supersonicbyte
Copy link
Collaborator Author

@vanvoorden

@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.98%. Comparing base (31e351e) to head (bb5313c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   96.97%   95.98%   -0.99%     
==========================================
  Files          11       11              
  Lines        1122     1193      +71     
==========================================
+ Hits         1088     1145      +57     
- Misses         34       48      +14     
Files with missing lines Coverage Δ
Tests/EquatableMacroTests.swift 98.23% <100.00%> (-1.77%) ⬇️
Files with missing lines Coverage Δ
Tests/EquatableMacroTests.swift 98.23% <100.00%> (-1.77%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb55d55...bb5313c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hassila
Copy link
Contributor

hassila commented Jul 29, 2025

Some tests missing like e.g. basicTypesComparedBeforeComplex ?

@supersonicbyte
Copy link
Collaborator Author

Some tests missing like e.g. basicTypesComparedBeforeComplex ?

It's there. The diff is a bit messy. The number of test cases is reduced from 34 to 17, because Rick duplicated the tests in the last PR. Now we have only tests which depend on Testing framework.

@supersonicbyte supersonicbyte merged commit 63e597c into main Jul 29, 2025
12 checks passed
@supersonicbyte supersonicbyte deleted the fix/drop-macro-testing branch July 29, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants