Skip to content

Conversation

@vanvoorden
Copy link
Contributor

@vanvoorden vanvoorden commented Jul 29, 2025

Description

Two small changes to our tests:

  • We conditionally import EquatableMacros consistent with the default template pattern.1
  • We restore some indent spaces lost from the switch to SwiftSyntaxMacrosGenericTestSupport.2

How Has This Been Tested?

Build and tested locally.

Minimal checklist:

  • I have performed a self-review of my own code
  • I have added DocC code-level documentation for any public interfaces exported by the package
  • I have added unit and/or integration tests that prove my fix is effective or that my feature works

Footnotes

  1. https://github.com/ordo-one/equatable/pull/21#issuecomment-3131230271

  2. https://github.com/ordo-one/equatable/commit/fb55d556f7a8fb2e9a7c6b8b94d9b258f79e467a

@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 98.37398% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.98%. Comparing base (31e351e) to head (d3b053d).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
Tests/EquatableMacroTests.swift 98.37% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   96.97%   95.98%   -0.99%     
==========================================
  Files          11       11              
  Lines        1122     1193      +71     
==========================================
+ Hits         1088     1145      +57     
- Misses         34       48      +14     
Files with missing lines Coverage Δ
Tests/EquatableMacroTests.swift 98.23% <98.37%> (-1.77%) ⬇️
Files with missing lines Coverage Δ
Tests/EquatableMacroTests.swift 98.23% <98.37%> (-1.77%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e597c...d3b053d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vanvoorden
Copy link
Contributor Author

Do we have the option to disable the codecov bot for testing code? Or is the intended behavior to also flag untested code in testing code?

@hassila
Copy link
Contributor

hassila commented Jul 31, 2025

Do we have the option to disable the codecov bot for testing code? Or is the intended behavior to also flag untested code in testing code?

Ping @freef4ll - Tests should reasonably be excluded by default for codecov.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants