-
Notifications
You must be signed in to change notification settings - Fork 11
feat(minor): [sc-24016] enable isolation specification in generated equatable confomance #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(minor): [sc-24016] enable isolation specification in generated equatable confomance #29
Conversation
…atable confomance
hassila
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I tried it with a sample view with 6.2 and .main isolation, looks working now!
Awesome! Let's wait to see does @vanvoorden has anything to say and we can merge it. |
Sources/EquatableMacros/Extensions/EquatableMacro/EquatableMacro+Equatable.swift
Show resolved
Hide resolved
|
@supersonicbyte Ahh… so we ended up bumping the min requirement to 602. I was thinking to leave the min requirement where it was but just bump the max requirement to 603. I would generally not always recommend bumping min requirements on point releases. These can be "breaking" changes if clients depend on more than one macro package. If package A has a max requirement of 601 and package B has a min requirement of 602 then trying to import them both together in one place means that SPM might not be able to resolve the dependencies. |
|
@vanvoorden you're right, definetely a break, sorry! I kinda confused this with something internal and forgot it's open source 😅 . EDIT: |
Description
As discussed here this PR implements a way to allow the user to specify the isolation of the generated conformances.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Minimal checklist:
DocCcode-level documentation for any public interfaces exported by the package