add gen1 and gen2 launch logic for Azure VMs #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@F-X64 it's fine for review, but without our CI I don't feel comfortable on merging it. ATM, it's possible to asses production releases locally only, without stage ones. |
Understood. I'll see to get the CI going as soon as possible. |
alexxa
force-pushed
the
gen1_gen2_azure
branch
from
451e63f to
5aaa87e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contributes to CLOUDX-1292
However, this introduces only logic to launch VMs of both gen1 and gen2 types, if 'instance_type' is missing. Corresponding suffixes are added to the resources naming for easier debugging, as illustrated
In a separate PR there should be addressed test cases specific to gen1/gen2.