Skip to content

Merge feature/events into foxy-devel #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 31, 2020
Merged

Merge feature/events into foxy-devel #24

merged 13 commits into from
Aug 31, 2020

Conversation

@ivanpauno
Copy link
Collaborator

@ivanpauno ivanpauno commented Aug 28, 2020

ivanpauno added 12 commits August 20, 2020 10:04
@ivanpauno
Add abstractions and minimal implementation of rcl events (#4)
c8ea478 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Add publisher liveliness lost event (#9)
7f0e6ab 
* Create LivelinessLostEvent

Signed-off-by: Ivan Santiago Paunovic <[email protected]>

* Fix linking issue

Signed-off-by: Ivan Santiago Paunovic <[email protected]>

* Rename disposeEventHandler to removeEventHandler

Signed-off-by: Ivan Santiago Paunovic <[email protected]>

* Use synchronized methods in EventHandlerImpl

Signed-off-by: Ivan Santiago Paunovic <[email protected]>

* Use createEventHandler instead of registerEventHanlder

Signed-off-by: Ivan Santiago Paunovic <[email protected]>

* nit

Signed-off-by: Ivan Santiago Paunovic <[email protected]>

* Clarify ownership of the event handle

Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Some code that compiles and doesn't break existing tests (#10)
3ae4c60 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Add offered qos incompatible event and event executor test (#11)
f36782a 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Move events.publisher_statuses to publisher.statuses (#12)
6d84553 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Add support for events in subscriptions (#13)
4fd64b3 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Add RequestedQosIncompatible subscription event status (#14)
257ed8b 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Test subscription events (#15)
46a5cdc 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Add OfferedDeadlineMissed QoS event (#17)
3300418 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Autoremove EventHandler from parent entity (#16)
9b1ad76 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Add RequestedDeadlineMissed subscription event (#19)
4de37c3 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno
Add LivelinessChanged subscription event (#18)
ff9a335 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno ivanpauno added the enhancement New feature or request label Aug 28, 2020
@ivanpauno ivanpauno requested a review from jacobperron August 28, 2020 21:35
@ivanpauno ivanpauno self-assigned this Aug 28, 2020
@ivanpauno
Add missing returns (#23)
f303f0b 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
jacobperron
jacobperron approved these changes Aug 28, 2020
View reviewed changes
Copy link

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give that I've already reviewed the incremental PRs, I didn't look too closely at this one.

@ivanpauno ivanpauno merged commit af574cb into foxy-devel Aug 31, 2020
@ivanpauno ivanpauno deleted the feature/events branch August 31, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jacobperron jacobperron jacobperron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ivanpauno ivanpauno

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ivanpauno @jacobperron